Remove Layer{Impl}::FilterIsAnimating.

Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 and should eventually be removed, prefer instead limiting
as seen in this patch.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2875133003
Cr-Commit-Position: refs/heads/master@{#471310}
Committed: https://chromium.googlesource.com/chromium/src/+/53a44329b63a7772bbd141040ba3744ccb49d881

[wkorman, 2017-05-11 20:30:13]

Description was changed from

==========
Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 prefer instead limiting as seen in this patch.

BUG=709137
==========

to

==========
Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 prefer instead limiting as seen in this patch.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[wkorman, 2017-05-11 20:34:43]

Description was changed from

==========
Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 prefer instead limiting as seen in this patch.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 and should eventually be removed, prefer instead limiting
as seen in this patch.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-05-11 20:35:05]

wkorman@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2017-05-11 20:41:01]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-05-11 20:41:02]

lgtm

[commit-bot: I haz the power, 2017-05-11 20:41:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 23:38:04]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[wkorman, 2017-05-12 03:07:01]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-05-12 03:07:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2875133003/#ps20001
(title: "Sync to head.")

[commit-bot: I haz the power, 2017-05-12 03:07:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 04:42:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 04:42:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2017-05-12 05:04:06]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:04:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 06:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:11:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2017-05-12 14:49:37]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2017-05-12 14:50:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 15:39:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494600577590880,
"parent_rev": "6b706e8b6fe5c879aef3a0cace6d8565070dbc95", "commit_rev":
"53a44329b63a7772bbd141040ba3744ccb49d881"}

[commit-bot: I haz the power, 2017-05-12 15:39:40]

Description was changed from

==========
Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 and should eventually be removed, prefer instead limiting
as seen in this patch.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove Layer{Impl}::FilterIsAnimating.

This logic is only used in two places:
1. unit tests
2. cc::PropertyTreeBuilder

For #1 we move the implementation into the unit test file directly.

For #2, this logic is only relevant for non-SPv2, and it's already
got its own copy of the exact same logic.

We could alternatively keep the implementation on Layer and LayerImpl,
and revise #2 to use it, but given that this method is not relevant
for SPv2 and should eventually be removed, prefer instead limiting
as seen in this patch.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2875133003
Cr-Commit-Position: refs/heads/master@{#471310}
Committed:
https://chromium.googlesource.com/chromium/src/+/53a44329b63a7772bbd141040ba3...
==========

[commit-bot: I haz the power, 2017-05-12 15:39:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53a44329b63a7772bbd141040ba3...