|
|
Created:
3 years, 7 months ago by Charlie Harrison Modified:
3 years, 7 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org, markusheintz_, subresource-filter-reviews_chromium.org, msramek+watch_chromium.org, raymes+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[subresource_filter] Add ContentSettings.{Exceptions,Default} metrics
BUG=689487
Review-Url: https://codereview.chromium.org/2875133002
Cr-Commit-Position: refs/heads/master@{#471612}
Committed: https://chromium.googlesource.com/chromium/src/+/3e994584017266c058161d4bd8856816191aeae5
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix ordering #Patch Set 3 : fix test #
Messages
Total messages: 28 (18 generated)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
csharrison@chromium.org changed reviewers: + bauerb@chromium.org, holte@chromium.org
bauerb, holte: PTAL?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
lgtm https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:84534: + <suffix name="subresource-filter" label="Subresource filter exceptions"/> Nit: Keep these alphabetic, please.
https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:84534: + <suffix name="subresource-filter" label="Subresource filter exceptions"/> On 2017/05/12 09:41:54, Bernhard Bauer wrote: > Nit: Keep these alphabetic, please. Done.
lgtm
The CQ bit was checked by csharrison@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org Link to the patchset: https://codereview.chromium.org/2875133002/#ps20001 (title: "fix ordering")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by csharrison@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2875133002/#ps40001 (title: "fix test")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494721134958070, "parent_rev": "0e3e575c7952a00e68740c9286048665be1404f7", "commit_rev": "3e994584017266c058161d4bd8856816191aeae5"}
Message was sent while issue was closed.
Description was changed from ========== [subresource_filter] Add ContentSettings.{Exceptions,Default} metrics BUG=689487 ========== to ========== [subresource_filter] Add ContentSettings.{Exceptions,Default} metrics BUG=689487 Review-Url: https://codereview.chromium.org/2875133002 Cr-Commit-Position: refs/heads/master@{#471612} Committed: https://chromium.googlesource.com/chromium/src/+/3e994584017266c058161d4bd885... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3e994584017266c058161d4bd885... |