Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 2875133002: [subresource_filter] Add ContentSettings.{Exceptions,Default} metrics (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, markusheintz_, subresource-filter-reviews_chromium.org, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Add ContentSettings.{Exceptions,Default} metrics BUG=689487 Review-Url: https://codereview.chromium.org/2875133002 Cr-Commit-Position: refs/heads/master@{#471612} Committed: https://chromium.googlesource.com/chromium/src/+/3e994584017266c058161d4bd8856816191aeae5

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix ordering #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/subresource_filter/subresource_filter_content_settings_manager_unittest.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
Charlie Harrison
bauerb, holte: PTAL?
3 years, 7 months ago (2017-05-11 19:05:14 UTC) #4
Bernhard Bauer
lgtm https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/histograms.xml#newcode84534 tools/metrics/histograms/histograms.xml:84534: + <suffix name="subresource-filter" label="Subresource filter exceptions"/> Nit: Keep ...
3 years, 7 months ago (2017-05-12 09:41:54 UTC) #7
Charlie Harrison
https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2875133002/diff/1/tools/metrics/histograms/histograms.xml#newcode84534 tools/metrics/histograms/histograms.xml:84534: + <suffix name="subresource-filter" label="Subresource filter exceptions"/> On 2017/05/12 09:41:54, ...
3 years, 7 months ago (2017-05-12 12:36:47 UTC) #8
Steven Holte
lgtm
3 years, 7 months ago (2017-05-13 00:16:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875133002/20001
3 years, 7 months ago (2017-05-13 01:35:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/370005)
3 years, 7 months ago (2017-05-13 02:11:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875133002/20001
3 years, 7 months ago (2017-05-13 02:15:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/293205)
3 years, 7 months ago (2017-05-13 03:42:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875133002/40001
3 years, 7 months ago (2017-05-14 00:19:02 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-14 01:07:18 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e994584017266c058161d4bd885...

Powered by Google App Engine
This is Rietveld 408576698