tools/telemetry/telemetry/core/backends/adb_commands.py - Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/adb_commands.py

Issue 287513002: [Android] Build android tools as PIE and add a wrapper for ICS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/backends/adb_commands.py

diff --git a/tools/telemetry/telemetry/core/backends/adb_commands.py b/tools/telemetry/telemetry/core/backends/adb_commands.py

index 9542d373652ee2f43ef7e388e31314705daa0b04..bc33dd8efffd531f464fc465c680a42a3e2998c8 100644

--- a/tools/telemetry/telemetry/core/backends/adb_commands.py

+++ b/tools/telemetry/telemetry/core/backends/adb_commands.py

@@ -113,6 +113,7 @@ def SetupPrebuiltTools(adb):

'forwarder_dist/device_forwarder',

'md5sum_dist/md5sum_bin',

'purge_ashmem',

+ 'run_pie',

]

host_tools = [

@@ -141,7 +142,7 @@ def SetupPrebuiltTools(adb):

platform_name = ('android' if t in device_tools else

platform.GetHostPlatform().GetOSName())

prebuilt_path = support_binaries.FindPath(executable, platform_name)

- if not os.path.exists(prebuilt_path):

+ if not prebuilt_path or not os.path.exists(prebuilt_path):

raise NotImplementedError("""

%s must be checked into cloud storage.

Instructions: