Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2875113002: Revert "named caches: move instead of symlinking" (Closed)

Created:
3 years, 7 months ago by M-A Ruel
Modified:
3 years, 7 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Vadim Sh.
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Revert "named caches: move instead of symlinking" This reverts commit d1ab255eac4e9ef88d437d476a586d22cda15952. Caused failures in task_runner_test.py and local_smoke_test.py. This passed the presubmit because the CL only touches client/, so the Swarming server side tests were bypassed. TBR=nodir@chromium.org BUG=715326 Review-Url: https://codereview.chromium.org/2875113002 Committed: https://github.com/luci/luci-py/commit/62d13e1c00497d006173c4d9cb496098284caf9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -261 lines) Patch
M client/named_cache.py View 11 chunks +96 lines, -129 lines 0 comments Download
M client/run_isolated.py View 8 chunks +16 lines, -22 lines 0 comments Download
M client/tests/named_cache_test.py View 3 chunks +37 lines, -90 lines 0 comments Download
M client/tests/run_isolated_test.py View 3 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
M-A Ruel
3 years, 7 months ago (2017-05-11 17:25:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875113002/1
3 years, 7 months ago (2017-05-11 17:25:51 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 17:28:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/62d13e1c00497d006173c4d9cb496098284caf9a

Powered by Google App Engine
This is Rietveld 408576698