DCHECK -> LOG_IF in payment request shipping address

chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc

Index: chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
index a5f43f9fb610b0d97cbbcd082763b4f6ba61d4c9..de7486cf37a59b56efeb614d991eaee84b86d55a 100644
--- a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
+++ b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
@@ -334,7 +334,7 @@ bool ShippingAddressEditorViewController::SaveFieldsToProfile(
       success = profile->SetInfo(autofill::AutofillType(field.second.type),
                                  field.first->text(), locale);
     }
-    DCHECK(success || ignore_errors)
+    LOG_IF(ERROR, success || ignore_errors)

[anthonyvd, 2017/05/11 20:06:29]

Are those going to be useful (especially after we disable the "Done" button
until all fields are valid)?

[MAD, 2017/05/11 20:19:53]

Should still be useful in browser tests. Doesn't the Done button enable state
depends on the return value of this function? So tests where the done button is
unexpectadly disabled could be easier to debug with this. No?

[anthonyvd, 2017/05/11 20:21:59]

I don't think so. This is called when the Done button is clicked (I think it's
currently always enabled). In any case, that's a good point.

         << "Can't setinfo(" << field.second.type << ", " << field.first->text();
     if (!success && !ignore_errors)
       return false;
@@ -356,9 +356,8 @@ bool ShippingAddressEditorViewController::SaveFieldsToProfile(
             combobox->GetTextForRow(combobox->selected_index()), locale);
       }
     }
-    DCHECK(success || ignore_errors)
+    LOG_IF(ERROR, success || ignore_errors)
         << "Can't setinfo(" << field.second.type << ", "
-
         << combobox->GetTextForRow(combobox->selected_index());
     if (!success && !ignore_errors)
       return false;