DCHECK -> LOG_IF in payment request shipping address

chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 316 matching lines @@
   for (const auto& field : text_fields()) {
     // Force a blur in case the value was left untouched.
     field.first->OnBlur();
     // ValidatingTextfield* is the key, EditorField is the value.
     if (field.first->invalid()) {
       success = false;
     } else {
       success = profile->SetInfo(autofill::AutofillType(field.second.type),
                                  field.first->text(), locale);
     }
-    DCHECK(success || ignore_errors)
+    LOG_IF(ERROR, success || ignore_errors)

[anthonyvd, 2017/05/11 20:06:29]

Are those going to be useful (especially after we disable the "Done" button
until all fields are valid)?

[MAD, 2017/05/11 20:19:53]

Should still be useful in browser tests. Doesn't the Done button enable state
depends on the return value of this function? So tests where the done button is
unexpectadly disabled could be easier to debug with this. No?

[anthonyvd, 2017/05/11 20:21:59]

I don't think so. This is called when the Done button is clicked (I think it's
currently always enabled). In any case, that's a good point.

         << "Can't setinfo(" << field.second.type << ", " << field.first->text();
     if (!success && !ignore_errors)
       return false;
   }
   for (const auto& field : comboboxes()) {
     // ValidatingCombobox* is the key, EditorField is the value.
     ValidatingCombobox* combobox = field.first;
     if (combobox->invalid()) {
       success = false;
     } else {
       if (combobox->id() == autofill::ADDRESS_HOME_COUNTRY) {
         success = profile->SetInfo(
             autofill::AutofillType(field.second.type),
             base::UTF8ToUTF16(country_codes_[combobox->selected_index()]),
             locale);
       } else {
         success = profile->SetInfo(
             autofill::AutofillType(field.second.type),
             combobox->GetTextForRow(combobox->selected_index()), locale);
       }
     }
-    DCHECK(success || ignore_errors)
+    LOG_IF(ERROR, success || ignore_errors)
         << "Can't setinfo(" << field.second.type << ", "
-
         << combobox->GetTextForRow(combobox->selected_index());
     if (!success && !ignore_errors)
       return false;
   }
   return success;
 }
 
 void ShippingAddressEditorViewController::OnComboboxModelChanged(
     views::Combobox* combobox) {
   if (combobox->id() != autofill::ADDRESS_HOME_STATE)
@@ skipping 58 matching lines @@
   bool is_required_valid = !field_.required;
   const base::string16 displayed_message =
       is_required_valid ? base::ASCIIToUTF16("")
                         : l10n_util::GetStringUTF16(
                               IDS_PAYMENTS_FIELD_REQUIRED_VALIDATION_MESSAGE);
   controller_->DisplayErrorMessageForField(field_, displayed_message);
   return is_required_valid;
 }
 
 }  // namespace payments