Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2875073002: Match histogram name to code (Closed)

Created:
3 years, 7 months ago by sfiera
Modified:
3 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Match histogram name to code This histogram *should* be named OptOuts, but I gave it the wrong name in the code. For now, I just want to be able to see it in UMA. Review-Url: https://codereview.chromium.org/2875073002 Cr-Commit-Position: refs/heads/master@{#471094} Committed: https://chromium.googlesource.com/chromium/src/+/2a03a77423e306ac78fcd89eaf09964153d7599a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sfiera
3 years, 7 months ago (2017-05-11 15:46:53 UTC) #2
rkaplow
lgtm
3 years, 7 months ago (2017-05-11 17:41:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875073002/1
3 years, 7 months ago (2017-05-11 20:23:39 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:32:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a03a77423e306ac78fcd89eaf09...

Powered by Google App Engine
This is Rietveld 408576698