Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2875043003: Remove base::SupportsWeakPtr from FrameReceiver (Closed)

Created:
3 years, 7 months ago by Chandan
Modified:
3 years, 7 months ago
Reviewers:
miu
CC:
chromium-reviews, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::SupportsWeakPtr from FrameReceiver FrameReceiver already creates a WeakPtrFactory instance to access its weak pointer. Therefore, it does not have to inherit base::SupportsWeakPtr. This CL removes SupportsWeakPtr and exposes its weak pointer outside the class via AsWeakPtr(). BUG=None Review-Url: https://codereview.chromium.org/2875043003 Cr-Commit-Position: refs/heads/master@{#471580} Committed: https://chromium.googlesource.com/chromium/src/+/2db565605f2c990edb8ab8cdb6fdd9cb80daff3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M media/cast/receiver/frame_receiver.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/receiver/frame_receiver.cc View 5 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Chandan
PTAL. Thank you.
3 years, 7 months ago (2017-05-11 15:41:26 UTC) #6
miu
lgtm
3 years, 7 months ago (2017-05-12 23:45:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875043003/1
3 years, 7 months ago (2017-05-12 23:45:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369969)
3 years, 7 months ago (2017-05-13 01:04:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875043003/1
3 years, 7 months ago (2017-05-13 04:42:21 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 08:15:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2db565605f2c990edb8ab8cdb6fd...

Powered by Google App Engine
This is Rietveld 408576698