Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2874983003:
Remove sunspider benchmark (Closed)
|
Created:
3 years, 7 months ago by nednguyen Modified:
3 years, 7 months ago Reviewers:
jochen (gone - plz use gerrit), Hannes Payer (out of office), payer, mvstanton, Camillo Bruni CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove sunspider benchmark
Since this benchmark doesn't use press benchmark harness, we clean it up to reduce
technical debt (also see https://bugs.chromium.org/p/chromium/issues/detail?id=708103#c13 for
further context). In addition, the benchmark has been disabled everywhere
due to a crash bug (crbug.com/712208), removing this won't reduce the
current coverage anyway.
BUG=712208, 714231
Review-Url: https://codereview.chromium.org/2874983003
Cr-Commit-Position: refs/heads/master@{#471812}
Committed: https://chromium.googlesource.com/chromium/src/+/14232dcc19c1dc66c2adad323dfda282b69cb0c8
Patch Set 1 #
Messages
Total messages: 29 (17 generated)
Description was changed from ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt. In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208 ========== to ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt. In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208, 714231 ==========
nednguyen@google.com changed reviewers: + cbruni@chromium.org, hpayer@chromium.org
nednguyen@google.com changed reviewers: + mvstanton@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt. In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208, 714231 ========== to ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt (also see https://bugs.chromium.org/p/chromium/issues/detail?id=708103#c13 for further context). In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208, 714231 ==========
Description was changed from ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt (also see https://bugs.chromium.org/p/chromium/issues/detail?id=708103#c13 for further context). In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208, 714231 ========== to ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt (also see https://bugs.chromium.org/p/chromium/issues/detail?id=708103#c13 for further context). In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208, 714231 ==========
lgtm
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/05/11 15:08:46, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Hannes or Michael, can either of you stamp because Camillo doesn't have Chromium committer?
On 2017/05/11 15:13:22, nednguyen wrote: > On 2017/05/11 15:08:46, commit-bot: I haz the power wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started once the patch has received an L-G-T-M from a full > > committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > > full super star committer. > > Committers are members of the group "project-chromium-committers". > > Note that this has nothing to do with OWNERS files. > > Hannes or Michael, can either of you stamp because Camillo doesn't have Chromium > committer? Ping.
jochen@chromium.org changed reviewers: + jochen@chromium.org
stamp-y lgtm
hpayer@google.com changed reviewers: + hpayer@google.com
lgtm
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494855643691590, "parent_rev":
"8fef90770e83bf54f895c971ff08d5016ddabefc", "commit_rev":
"14232dcc19c1dc66c2adad323dfda282b69cb0c8"}
Message was sent while issue was closed.
Description was changed from ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt (also see https://bugs.chromium.org/p/chromium/issues/detail?id=708103#c13 for further context). In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208, 714231 ========== to ========== Remove sunspider benchmark Since this benchmark doesn't use press benchmark harness, we clean it up to reduce technical debt (also see https://bugs.chromium.org/p/chromium/issues/detail?id=708103#c13 for further context). In addition, the benchmark has been disabled everywhere due to a crash bug (crbug.com/712208), removing this won't reduce the current coverage anyway. BUG=712208, 714231 Review-Url: https://codereview.chromium.org/2874983003 Cr-Commit-Position: refs/heads/master@{#471812} Committed: https://chromium.googlesource.com/chromium/src/+/14232dcc19c1dc66c2adad323dfd... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/14232dcc19c1dc66c2adad323dfd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
