Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2874973003: Add more equivalence tests for ElementEnvironment (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -29 lines) Patch
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 5 chunks +12 lines, -20 lines 2 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 2 chunks +67 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-11 09:14:06 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2874973003/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart File pkg/compiler/lib/src/serialization/equivalence.dart (right): https://codereview.chromium.org/2874973003/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart#newcode81 pkg/compiler/lib/src/serialization/equivalence.dart:81: if (keyEquivalence(key1, key2)) { maybe we need tests ...
3 years, 7 months ago (2017-05-11 19:12:24 UTC) #3
Johnni Winther
https://codereview.chromium.org/2874973003/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart File pkg/compiler/lib/src/serialization/equivalence.dart (right): https://codereview.chromium.org/2874973003/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart#newcode81 pkg/compiler/lib/src/serialization/equivalence.dart:81: if (keyEquivalence(key1, key2)) { On 2017/05/11 19:12:24, Siggi Cherem ...
3 years, 7 months ago (2017-05-12 08:11:25 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-12 08:16:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
822bbbb71a0c88e1bef2f3bdd76695682cadb436 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698