Add more equivalence tests for ElementEnvironment

pkg/compiler/lib/src/serialization/equivalence.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Functions for asserting equivalence across serialization.
 
 library dart2js.serialization.equivalence;
 
 import '../closure.dart';
 import '../common/resolution.dart';
@@ skipping 60 matching lines @@
 
 /// Returns `true` if the content of [map1] and [map2] is equivalent using
 /// [keyEquivalence] and [valueEquivalence] to determine key/value equivalence.
 bool areMapsEquivalent(Map map1, Map map2,
     [bool keyEquivalence(a, b) = equality,
     bool valueEquivalence(a, b) = equality]) {
   Set remaining = map2.keys.toSet();
   for (var key1 in map1.keys) {
     bool found = false;
     for (var key2 in map2.keys) {
-      if (keyEquivalence(key2, key2)) {
+      if (keyEquivalence(key1, key2)) {

[Siggi Cherem (dart-lang), 2017/05/11 19:12:24]

maybe we need tests for the equivalent checks :)

[Johnni Winther, 2017/05/12 08:11:25]

;)

         found = true;
         remaining.remove(key2);
         if (!valueEquivalence(map1[key1], map2[key2])) {
           return false;
         }
         break;
       }
     }
     if (!found) {
       return false;
@@ skipping 815 matching lines @@
 
   bool visit(ConstantValue value1, ConstantValue value2) {
     if (identical(value1, value2)) return true;
     return strategy.test(value1, value2, 'kind', value1.kind, value2.kind) &&
         value1.accept(this, value2);
   }
 
   @override
   bool visitConstructed(
       ConstructedConstantValue value1, ConstructedConstantValue value2) {
-    ResolutionInterfaceType type1 = value1.type;
-    ResolutionInterfaceType type2 = value2.type;
-    return strategy.testTypes(value1, value2, 'type', type1, type2) &&
+    return strategy.testTypes(
+            value1, value2, 'type', value1.type, value2.type) &&
         strategy.testMaps(
             value1,
             value2,
             'fields',
             value1.fields,
             value2.fields,
-            areElementsEquivalent,
+            strategy.elementEquivalence,
             (a, b) => strategy.testConstantValues(
                 value1, value2, 'fields.values', a, b));
   }
 
   @override
   bool visitFunction(
       FunctionConstantValue value1, FunctionConstantValue value2) {
-    MethodElement method1 = value1.element;
-    MethodElement method2 = value2.element;
-    return strategy.testElements(value1, value2, 'element', method1, method2);
+    return strategy.testElements(
+        value1, value2, 'element', value1.element, value2.element);
   }
 
   @override
   bool visitList(ListConstantValue value1, ListConstantValue value2) {
-    ResolutionInterfaceType type1 = value1.type;
-    ResolutionInterfaceType type2 = value2.type;
-    return strategy.testTypes(value1, value2, 'type', type1, type2) &&
+    return strategy.testTypes(
+            value1, value2, 'type', value1.type, value2.type) &&
         strategy.testConstantValueLists(
             value1, value2, 'entries', value1.entries, value2.entries);
   }
 
   @override
   bool visitMap(MapConstantValue value1, MapConstantValue value2) {
-    ResolutionInterfaceType type1 = value1.type;
-    ResolutionInterfaceType type2 = value2.type;
-    return strategy.testTypes(value1, value2, 'type', type1, type2) &&
+    return strategy.testTypes(
+            value1, value2, 'type', value1.type, value2.type) &&
         strategy.testConstantValueLists(
             value1, value2, 'keys', value1.keys, value2.keys) &&
         strategy.testConstantValueLists(
             value1, value2, 'values', value1.values, value2.values);
   }
 
   @override
   bool visitType(TypeConstantValue value1, TypeConstantValue value2) {
-    ResolutionInterfaceType type1 = value1.type;
-    ResolutionInterfaceType type2 = value2.type;
-    return strategy.testTypes(value1, value2, 'type', type1, type2);
+    return strategy.testTypes(value1, value2, 'type', value1.type, value2.type);
   }
 
   @override
   bool visitBool(BoolConstantValue value1, BoolConstantValue value2) {
     return strategy.test(value1, value2, 'primitiveValue',
         value1.primitiveValue, value2.primitiveValue);
   }
 
   @override
   bool visitDouble(DoubleConstantValue value1, DoubleConstantValue value2) {
@@ skipping 37 matching lines @@
       SyntheticConstantValue value1, SyntheticConstantValue value2) {
     return strategy.test(
             value1, value2, 'payload', value1.payload, value2.payload) &&
         strategy.test(
             value1, value2, 'valueKind', value1.valueKind, value2.valueKind);
   }
 
   @override
   bool visitInterceptor(
       InterceptorConstantValue value1, InterceptorConstantValue value2) {
-    ClassElement cls1 = value1.cls;
-    ClassElement cls2 = value2.cls;
-    return strategy.testElements(value1, value2, 'cls', cls1, cls2);
+    return strategy.testElements(value1, value2, 'cls', value1.cls, value2.cls);
   }
 }
 
 /// Tests the equivalence of [impact1] and [impact2] using [strategy].
 bool testResolutionImpactEquivalence(
     ResolutionImpact impact1, ResolutionImpact impact2,
     {TestStrategy strategy = const TestStrategy()}) {
   return strategy.testSets(impact1, impact2, 'constSymbolNames',
           impact1.constSymbolNames, impact2.constSymbolNames) &&
       strategy.testSets(
@@ skipping 1110 matching lines @@
 }
 
 bool areMetadataAnnotationsEquivalent(
     MetadataAnnotation metadata1, MetadataAnnotation metadata2) {
   if (metadata1 == metadata2) return true;
   if (metadata1 == null || metadata2 == null) return false;
   return areElementsEquivalent(
           metadata1.annotatedElement, metadata2.annotatedElement) &&
       areConstantsEquivalent(metadata1.constant, metadata2.constant);
 }