|
|
Created:
3 years, 7 months ago by yizhou.jiang Modified:
3 years, 7 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll WebGL 73b300f..6517159
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300f..6517159
BUG=693090, 712096
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2874933003
Cr-Commit-Position: refs/heads/master@{#471635}
Committed: https://chromium.googlesource.com/chromium/src/+/df78633101a43642053c681b8530c88bf7032e06
Patch Set 1 : Roll in webgl #Patch Set 2 : modify expectation file #
Total comments: 2
Messages
Total messages: 38 (28 generated)
The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by yizhou.jiang@intel.com to run a CQ dry run
Description was changed from ========== Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
yizhou.jiang@intel.com changed reviewers: + yunchao.he@intel.com
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300... BUG=693090,712096 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
yizhou.jiang@intel.com changed reviewers: + jie.a.chen@intel.com, yang.gu@intel.com, zmo@google.com
yizhou.jiang@intel.com changed reviewers: + zmo@chromium.org - zmo@google.com
On 2017/05/12 02:23:40, yizhou.jiang wrote: > mailto:yizhou.jiang@intel.com changed reviewers: > + mailto:zmo@chromium.org > - mailto:zmo@google.com Zhenyao, Yunchao, this patch roll in webgl cts, please take a look.
On 2017/05/12 02:24:51, yizhou.jiang wrote: > On 2017/05/12 02:23:40, yizhou.jiang wrote: > > mailto:yizhou.jiang@intel.com changed reviewers: > > + mailto:zmo@chromium.org > > - mailto:zmo@google.com > > Zhenyao, Yunchao, this patch roll in webgl cts, please take a look. I will update webgl2_conformance_expectations.py and reset bug 693090(fail on windows nvidia) in patch 2866663002.
GLTM. Thanks!
LGTM
lgtm https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:46: self.Fail('conformance2/textures/misc/tex-srgb-mipmap.html', bug=712096) Assume this can be removed or least move back to the Win/ANGLE only entry once https://codereview.chromium.org/2866663002/ lands?
https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:46: self.Fail('conformance2/textures/misc/tex-srgb-mipmap.html', bug=712096) On 2017/05/12 17:54:48, Zhenyao Mo wrote: > Assume this can be removed or least move back to the Win/ANGLE only entry once > https://codereview.chromium.org/2866663002/ lands? Yes, I will move it back in 2866663002 after this landed.
yizhou.jiang@intel.com changed reviewers: + kbr@chromium.org
The CQ bit was checked by yizhou.jiang@intel.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
The CQ bit was checked by yunchao.he@intel.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20002, "attempt_start_ts": 1494775893797460, "parent_rev": "5f9c1644745e7e222d0f9ad0984d62612935eef4", "commit_rev": "df78633101a43642053c681b8530c88bf7032e06"}
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300... BUG=693090,712096 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300... BUG=693090,712096 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2874933003 Cr-Commit-Position: refs/heads/master@{#471635} Committed: https://chromium.googlesource.com/chromium/src/+/df78633101a43642053c681b8530... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20002) as https://chromium.googlesource.com/chromium/src/+/df78633101a43642053c681b8530... |