Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Issue 2874933003: Roll WebGL 73b300f..6517159 (Closed)

Created:
3 years, 7 months ago by yizhou.jiang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL 73b300f..6517159 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/73b300f..6517159 BUG=693090, 712096 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2874933003 Cr-Commit-Position: refs/heads/master@{#471635} Committed: https://chromium.googlesource.com/chromium/src/+/df78633101a43642053c681b8530c88bf7032e06

Patch Set 1 : Roll in webgl #

Patch Set 2 : modify expectation file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 chunks +1 line, -2 lines 2 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_revision.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (28 generated)
yizhou.jiang
On 2017/05/12 02:23:40, yizhou.jiang wrote: > mailto:yizhou.jiang@intel.com changed reviewers: > + mailto:zmo@chromium.org > - mailto:zmo@google.com ...
3 years, 7 months ago (2017-05-12 02:24:51 UTC) #23
yizhou.jiang
On 2017/05/12 02:24:51, yizhou.jiang wrote: > On 2017/05/12 02:23:40, yizhou.jiang wrote: > > mailto:yizhou.jiang@intel.com changed ...
3 years, 7 months ago (2017-05-12 07:27:56 UTC) #24
yunchao
GLTM. Thanks!
3 years, 7 months ago (2017-05-12 07:43:26 UTC) #25
yunchao
LGTM
3 years, 7 months ago (2017-05-12 07:44:05 UTC) #26
Zhenyao Mo
lgtm https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode46 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:46: self.Fail('conformance2/textures/misc/tex-srgb-mipmap.html', bug=712096) Assume this can be removed or ...
3 years, 7 months ago (2017-05-12 17:54:48 UTC) #27
yizhou.jiang
https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2874933003/diff/20002/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode46 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:46: self.Fail('conformance2/textures/misc/tex-srgb-mipmap.html', bug=712096) On 2017/05/12 17:54:48, Zhenyao Mo wrote: > ...
3 years, 7 months ago (2017-05-13 03:14:26 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874933003/20002
3 years, 7 months ago (2017-05-13 09:50:25 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/5254)
3 years, 7 months ago (2017-05-13 10:06:09 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874933003/20002
3 years, 7 months ago (2017-05-14 15:31:43 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-05-14 17:33:24 UTC) #38
Message was sent while issue was closed.
Committed patchset #2 (id:20002) as
https://chromium.googlesource.com/chromium/src/+/df78633101a43642053c681b8530...

Powered by Google App Engine
This is Rietveld 408576698