Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Issue 2874933002: Don't enforce X-Frame-Options for downloads. (Closed)

Created:
3 years, 7 months ago by nasko
Modified:
3 years, 7 months ago
Reviewers:
alexmos, arthursonzogni
CC:
chromium-reviews, jam, David Trainor- moved to gerrit, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't enforce X-Frame-Options for downloads. This CL excludes downloads from X-Frame-Options checks with PlzNavigate. BUG=717971 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2874933002 Cr-Commit-Position: refs/heads/master@{#470772} Committed: https://chromium.googlesource.com/chromium/src/+/1aa98d7cf548e42ef1a75828caa6d6831445172b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a reference to 717971 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M content/browser/download/download_browsertest.cc View 1 2 chunks +29 lines, -0 lines 0 comments Download
M content/browser/frame_host/ancestor_throttle.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/download/download-with-xfo-deny.html View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/download/download-with-xfo-deny.html.mock-http-headers View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nasko
Hey Alex, Can you review this CL for me? It ensures that downloads are not ...
3 years, 7 months ago (2017-05-10 23:31:30 UTC) #4
alexmos
Nice! LGTM https://codereview.chromium.org/2874933002/diff/1/content/browser/download/download_browsertest.cc File content/browser/download/download_browsertest.cc (right): https://codereview.chromium.org/2874933002/diff/1/content/browser/download/download_browsertest.cc#newcode2721 content/browser/download/download_browsertest.cc:2721: // initiates a download in an iframe ...
3 years, 7 months ago (2017-05-10 23:41:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874933002/20001
3 years, 7 months ago (2017-05-11 00:16:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 02:01:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1aa98d7cf548e42ef1a75828caa6...

Powered by Google App Engine
This is Rietveld 408576698