Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2874923002:
Omnibox UI Experiments: Port vertical margin experiment to Cocoa. (Closed)
|
Created:
3 years, 7 months ago by tommycli Modified:
3 years, 7 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews, jdonnelly+watch_chromium.org, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionOmnibox UI Experiments: Port vertical margin experiment to Cocoa.
Ports the Omnibox UI vertical margin experiment to Cocoa.
See: https://codereview.chromium.org/2854263002/
BUG=717777
Review-Url: https://codereview.chromium.org/2874923002
Cr-Commit-Position: refs/heads/master@{#471818}
Committed: https://chromium.googlesource.com/chromium/src/+/ea05207e94618c286f12bbf97f5f65ecc552d663
Patch Set 1 #Patch Set 2 : simplify #Patch Set 3 : remove a pixel #
Total comments: 4
Patch Set 4 : make constexpr #
Messages
Total messages: 24 (19 generated)
Description was changed from ========== Omnibox UI Experiments: Port vertical margin experiment to Cocoa. Ports the Omnibox UI vertical margin experiment to Cocoa. BUG=717777 ========== to ========== Omnibox UI Experiments: Port vertical margin experiment to Cocoa. Ports the Omnibox UI vertical margin experiment to Cocoa. See: https://codereview.chromium.org/2854263002/ BUG=717777 ==========
tommycli@chromium.org changed reviewers: + groby@chromium.org
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
groby: PTAL, screenshot and eng doc in bug. https://codereview.chromium.org/2874923002/diff/40001/chrome/browser/ui/cocoa... File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2874923002/diff/40001/chrome/browser/ui/cocoa... chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:534: origin.x += imageSize + kMaterialImageXOffset; The previous version (adding vertical image padding to the x axis) doesn't really make sense... The new version makes more sense. The difference is 1px and I can't tell the difference. I'm guessing the previous version is a mistake...
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
lgtm https://codereview.chromium.org/2874923002/diff/40001/chrome/browser/ui/cocoa... File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2874923002/diff/40001/chrome/browser/ui/cocoa... chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:37: const CGFloat kMaterialExtraVerticalImagePadding = 2.0; constexpr, please https://codereview.chromium.org/2874923002/diff/40001/chrome/browser/ui/cocoa... chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:534: origin.x += imageSize + kMaterialImageXOffset; On 2017/05/10 23:41:09, tommycli wrote: > The previous version (adding vertical image padding to the x axis) doesn't > really make sense... > > The new version makes more sense. The difference is 1px and I can't tell the > difference. > > I'm guessing the previous version is a mistake... Acknowledged.
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thanks! https://codereview.chromium.org/2874923002/diff/40001/chrome/browser/ui/cocoa... File chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm (right): https://codereview.chromium.org/2874923002/diff/40001/chrome/browser/ui/cocoa... chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm:37: const CGFloat kMaterialExtraVerticalImagePadding = 2.0; On 2017/05/11 14:57:37, groby wrote: > constexpr, please Done.
The CQ bit was unchecked by tommycli@chromium.org
The CQ bit was checked by tommycli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org Link to the patchset: https://codereview.chromium.org/2874923002/#ps60001 (title: "make constexpr")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494867777178290,
"parent_rev": "8b69ae3d8ac29e279b8f3b2e94d06ee6a12297ad", "commit_rev":
"ea05207e94618c286f12bbf97f5f65ecc552d663"}
Message was sent while issue was closed.
Description was changed from ========== Omnibox UI Experiments: Port vertical margin experiment to Cocoa. Ports the Omnibox UI vertical margin experiment to Cocoa. See: https://codereview.chromium.org/2854263002/ BUG=717777 ========== to ========== Omnibox UI Experiments: Port vertical margin experiment to Cocoa. Ports the Omnibox UI vertical margin experiment to Cocoa. See: https://codereview.chromium.org/2854263002/ BUG=717777 Review-Url: https://codereview.chromium.org/2874923002 Cr-Commit-Position: refs/heads/master@{#471818} Committed: https://chromium.googlesource.com/chromium/src/+/ea05207e94618c286f12bbf97f5f... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ea05207e94618c286f12bbf97f5f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
