Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html

Issue 2874873003: bluetooth: Implement simulateGATTConnectionResponse() (Closed)
Patch Set: Merge branch 'bluetooth-generate-with-headers' into bluetooth-simulate-gatt-discovery-complete Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html b/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html
index 9aa12e37f081da191561ab58776152625bbb0f8e..c11beaa7413a21f04184c3a5149f9cc75996ec6a 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html
@@ -2,16 +2,20 @@
<script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script>
<script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>
+<script src="../../../resources/bluetooth/web-bluetooth-test.js"></script>
+<script src="../../../resources/mojo-helpers.js"></script>
<script>
'use strict';
promise_test(t => {
- return setBluetoothFakeAdapter('FailingConnectionsAdapter')
- .then(() => requestDeviceWithKeyDown({
- filters: [{services: [errorUUID(0x1) /* in progress error */]}]}))
- .then(device => {
- promise_rejects(t, 'NetworkError', device.gatt.connect());
- })
- .then(runGarbageCollection);
+ return setUpPreconnectedDevice({}).then(fake_peripheral => {
+ return requestDeviceWithKeyDown({acceptAllDevices: true})
+ .then(device => {
+ promise_rejects(t, 'NetworkError', device.gatt.connect());
+ })
+ .then(runGarbageCollection)
scheib 2017/05/12 05:43:56 We should file an issue if not already done on 'ru
ortuno 2017/05/15 07:01:31 Do we need one? I wasn't planning on usptreaming t
+ .then(() => fake_peripheral.simulateGATTConnectionResponse(
+ {code: HCI_CONNECTION_TIMEOUT}));
+ });
}, 'Garbage collection ran during a connect call that fails. ' +
'Should not crash.');
</script>

Powered by Google App Engine
This is Rietveld 408576698