third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html - Issue 2874873003: bluetooth: Implement simulateGATTConnectionResponse()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html

Issue 2874873003: bluetooth: Implement simulateGATTConnectionResponse() (Closed)

Patch Set: Merge branch 'bluetooth-generate-with-headers' into bluetooth-simulate-gatt-discovery-complete Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html ('K') | « third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html ('k') | third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script src="../../../resources/bluetooth/web-bluetooth-test.js"></script>

	6 <script src="../../../resources/mojo-helpers.js"></script>

5 <script>	7 <script>

6 'use strict';	8 'use strict';

7 promise_test(t => {	9 promise_test(t => {

8 return setBluetoothFakeAdapter('FailingConnectionsAdapter')	10 return setUpPreconnectedDevice({}).then(fake_peripheral => {

9 .then(() => requestDeviceWithKeyDown({	11 return requestDeviceWithKeyDown({acceptAllDevices: true})

10 filters: [{services: [errorUUID(0x1) /* in progress error */]}]}))	12 .then(device => {

11 .then(device => {	13 promise_rejects(t, 'NetworkError', device.gatt.connect());

12 promise_rejects(t, 'NetworkError', device.gatt.connect());	14 })

13 })	15 .then(runGarbageCollection)
	scheib 2017/05/12 05:43:56 We should file an issue if not already done on 'ru We should file an issue if not already done on 'runGarbageCollection' ortuno 2017/05/15 07:01:31 Do we need one? I wasn't planning on usptreaming t Show quoted text On 2017/05/12 at 05:43:56, scheib wrote: > We should file an issue if not already done on 'runGarbageCollection' Do we need one? I wasn't planning on usptreaming this. I think we would get quite a bit of push back on it; I've been told in the past that we should not be testing this through layout tests but rather with unit tests.
14 .then(runGarbageCollection);	16 .then(() => fake_peripheral.simulateGATTConnectionResponse(

	17 {code: HCI_CONNECTION_TIMEOUT}));

	18 });

15 }, 'Garbage collection ran during a connect call that fails. ' +	19 }, 'Garbage collection ran during a connect call that fails. ' +

16 'Should not crash.');	20 'Should not crash.');

17 </script>	21 </script>

OLD	NEW