[Payments] Record use stats after payment request completion.

[Payments] Record use stats after payment request completion.

BUG=720605
Review-Url: https://codereview.chromium.org/2874873002
Cr-Commit-Position: refs/heads/master@{#471042}
Committed: https://chromium.googlesource.com/chromium/src/+/8a93b2794165aa76a669ad2adc0690a45b4fd679

[sebsg, 2017-05-10 21:20:24]

Patchset #1 (id:1) has been deleted

[sebsg, 2017-05-10 21:22:58]

Patchset #1 (id:20001) has been deleted

[sebsg, 2017-05-10 21:23:10]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[sebsg, 2017-05-10 21:23:24]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-05-10 21:23:25]

Hi Math, PTAL?

[sebsg, 2017-05-10 21:23:26]

Hi Math, PTAL?

[commit-bot: I haz the power, 2017-05-10 21:24:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 21:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:54:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-05-11 01:25:27]

lgtm with comment

https://codereview.chromium.org/2874873002/diff/40001/components/payments/cor...
File components/payments/core/autofill_payment_instrument.cc (right):

https://codereview.chromium.org/2874873002/diff/40001/components/payments/cor...
components/payments/core/autofill_payment_instrument.cc:111: // Record the use
of the billing address.
Yeah I'm not sure about that one, because we use address stats to rank addresses
in the shipping selector and in Autofill. Using a card that happens to have a
specific billing address doesn't mean you like that address as a shipping
address... 

Your earlier point about not deleting billing addresses after some time has
passed, but at that time we can simply check that the address is not used as a
billing address before deleting it. 

Can we remove this statement?

[sebsg, 2017-05-11 17:49:18]

Thanks, sending to CQ

https://codereview.chromium.org/2874873002/diff/40001/components/payments/cor...
File components/payments/core/autofill_payment_instrument.cc (right):

https://codereview.chromium.org/2874873002/diff/40001/components/payments/cor...
components/payments/core/autofill_payment_instrument.cc:111: // Record the use
of the billing address.
On 2017/05/11 01:25:27, Mathieu wrote:
> Yeah I'm not sure about that one, because we use address stats to rank
addresses
> in the shipping selector and in Autofill. Using a card that happens to have a
> specific billing address doesn't mean you like that address as a shipping
> address... 
> 
> Your earlier point about not deleting billing addresses after some time has
> passed, but at that time we can simply check that the address is not used as a
> billing address before deleting it. 
> 
> Can we remove this statement?

Done.

[sebsg, 2017-05-11 17:49:24]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-05-11 17:49:25]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2874873002/#ps60001
(title: "Removed billing address log")

[commit-bot: I haz the power, 2017-05-11 17:50:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 19:30:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494524964854570,
"parent_rev": "c30b5ae26dd734cc3b69b8d49f4d95c426d22750", "commit_rev":
"8a93b2794165aa76a669ad2adc0690a45b4fd679"}

[commit-bot: I haz the power, 2017-05-11 19:30:35]

Description was changed from

==========
[Payments] Record use stats after payment request completion.

BUG=720605
==========

to

==========
[Payments] Record use stats after payment request completion.

BUG=720605

Review-Url: https://codereview.chromium.org/2874873002
Cr-Commit-Position: refs/heads/master@{#471042}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a93b2794165aa76a669ad2adc06...
==========

[commit-bot: I haz the power, 2017-05-11 19:30:36]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8a93b2794165aa76a669ad2adc06...