Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2874833004: [array] Fast allocation in Array.p.map (Closed)

Created:
3 years, 7 months ago by jgruber
Modified:
3 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[array] Fast allocation in Array.p.map and Array.p.filter No need to call through ConstructJS -> ArrayCode -> ArrayConstructorStub -> AllocateJSArray if we can call AllocateJSArray directly. This also moves ArraySpeciesCreate to builtins-array-gen to free up space in the binary. BUG=v8:6354 Review-Url: https://codereview.chromium.org/2874833004 Cr-Commit-Position: refs/heads/master@{#45276} Committed: https://chromium.googlesource.com/v8/v8/+/11d80c95caac115e3c6daf8545b2a7e04a8f1c3d

Patch Set 1 #

Patch Set 2 : Don't load the map twice #

Patch Set 3 : FAST_HOLEY #

Patch Set 4 : Move fast path to ArraySpeciesCreate #

Patch Set 5 : Check len smi-ness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -45 lines) Patch
M src/builtins/builtins-array-gen.cc View 1 2 3 4 3 chunks +48 lines, -32 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 27 (23 generated)
jgruber
3 years, 7 months ago (2017-05-12 11:17:43 UTC) #19
mvstanton
I like it! LGTM.
3 years, 7 months ago (2017-05-12 11:24:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874833004/80001
3 years, 7 months ago (2017-05-12 11:35:48 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 11:37:32 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/11d80c95caac115e3c6daf8545b2a7e04a8...

Powered by Google App Engine
This is Rietveld 408576698