Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2874823002: Reland: Allow autotest extension to access system.display (Closed)

Created:
3 years, 7 months ago by victorhsieh
Modified:
3 years, 7 months ago
Reviewers:
stevenjb, victorhsieh0
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, afakhry
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Allow autotest extension to access system.display system.display is currently only allowed for a few cases. Grant autotest extension to use the API for test purpose, too. TEST=Autotest works TEST=Change display setting. Did not crash with null check. BUG=719804 BUG=712705 Review-Url: https://codereview.chromium.org/2874823002 Cr-Commit-Position: refs/heads/master@{#470737} Committed: https://chromium.googlesource.com/chromium/src/+/90e6006c41c0013b8f48c02263e3a44c32da0c9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M extensions/browser/api/system_display/system_display_api.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
victorhsieh0
PTAL
3 years, 7 months ago (2017-05-10 17:35:46 UTC) #2
stevenjb
lgtm
3 years, 7 months ago (2017-05-10 18:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874823002/1
3 years, 7 months ago (2017-05-10 18:54:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/440975)
3 years, 7 months ago (2017-05-10 20:35:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874823002/1
3 years, 7 months ago (2017-05-10 20:58:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 22:38:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90e6006c41c0013b8f48c02263e3...

Powered by Google App Engine
This is Rietveld 408576698