Remove one use of ScrollNode's owning_layer_id for StickyPositionOffset

Remove one use of ScrollNode's owning_layer_id for StickyPositionOffset

This patch removes one more owning_layer_id. This is the first of many
related to scroll offsets.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2874793004
Cr-Commit-Position: refs/heads/master@{#471465}
Committed: https://chromium.googlesource.com/chromium/src/+/b0fbfe1542e538079f74439a578a2b08cb8a88ba

[pdr., 2017-05-10 23:13:39]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wkorman@chromium.org

[chrishtr, 2017-05-10 23:39:57]

Looks good, as long as the transform node always gets the scroll offset.

[pdr., 2017-05-10 23:44:51]

pdr@chromium.org changed reviewers:
+ enne@chromium.org

[pdr., 2017-05-10 23:45:46]

On 2017/05/10 at 23:39:57, chrishtr wrote:
> Looks good, as long as the transform node always gets the scroll offset.

In the latest patch I added a DCHECK that this patch doesn't change the scroll
offset value. It doesn't hit anywhere so I think this is good.

+reviewer Enne for OWNERS and review.

[pdr., 2017-05-10 23:45:54]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 23:46:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:29:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:29:41]

Dry run: This issue passed the CQ dry run.

[wkorman, 2017-05-11 03:07:38]

lgtm

[pdr., 2017-05-12 16:05:22]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:05:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 16:15:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:15:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdr., 2017-05-12 22:08:47]

enne or chris, can you review this?

[chrishtr, 2017-05-12 22:11:21]

lgtm

https://codereview.chromium.org/2874793004/diff/20001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2874793004/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:361:
DCHECK(property_trees.scroll_tree.current_scroll_offset(
Add a note that this can be removed later, and is just here
to ensure correctness?

[pdr., 2017-05-12 22:12:29]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-12 22:13:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-05-12 22:15:28]

lgtm

https://codereview.chromium.org/2874793004/diff/20001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2874793004/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:361:
DCHECK(property_trees.scroll_tree.current_scroll_offset(
Can you DCHECK_EQ this?

[pdr., 2017-05-12 22:22:08]

The CQ bit was unchecked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-12 22:22:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494627149685660,
"parent_rev": "1b070387595668ec438ffec65185e61017300e3c", "commit_rev":
"b0fbfe1542e538079f74439a578a2b08cb8a88ba"}

[commit-bot: I haz the power, 2017-05-12 22:22:28]

Description was changed from

==========
Remove one use of ScrollNode's owning_layer_id for StickyPositionOffset

This patch removes one more owning_layer_id. This is the first of many
related to scroll offsets.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove one use of ScrollNode's owning_layer_id for StickyPositionOffset

This patch removes one more owning_layer_id. This is the first of many
related to scroll offsets.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2874793004
Cr-Commit-Position: refs/heads/master@{#471465}
Committed:
https://chromium.googlesource.com/chromium/src/+/b0fbfe1542e538079f74439a578a...
==========

[commit-bot: I haz the power, 2017-05-12 22:22:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b0fbfe1542e538079f74439a578a...

[pdr., 2017-05-12 22:27:01]

On 2017/05/12 at 22:22:29, commit-bot wrote:
> Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b0fbfe1542e538079f74439a578a...

Sorry enne. I clicked cancel commit but it was already committing.

Chris and I discussed this offline a bit. There are ~10 of these dchecks that
are just ensuring we don't mess up owning_layer_id logic during this refactor.
They will all be removed soon.