Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2874783003: Remove DEBUG_TEXT_AUTOSIZING_ON_DESKTOP altogether. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DEBUG_TEXT_AUTOSIZING_ON_DESKTOP altogether. Autosizing can be triggered through devtools on desktop nowadays. BUG=675877 Review-Url: https://codereview.chromium.org/2874783003 Cr-Commit-Position: refs/heads/master@{#471090} Committed: https://chromium.googlesource.com/chromium/src/+/c6aa511064b40136b0bf83d926690898b285f114

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M third_party/WebKit/Source/core/frame/Settings.cpp View 1 chunk +1 line, -8 lines 3 comments Download

Messages

Total messages: 38 (21 generated)
Nico
3 years, 7 months ago (2017-05-10 16:07:59 UTC) #3
pdr.
https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp File third_party/WebKit/Source/core/frame/Settings.cpp (left): https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp#oldcode65 third_party/WebKit/Source/core/frame/Settings.cpp:65: : text_autosizing_window_size_override_(320, 480), I think we need to fully ...
3 years, 7 months ago (2017-05-10 19:01:16 UTC) #9
Nico
https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp File third_party/WebKit/Source/core/frame/Settings.cpp (left): https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp#oldcode65 third_party/WebKit/Source/core/frame/Settings.cpp:65: : text_autosizing_window_size_override_(320, 480), On 2017/05/10 19:01:16, pdr. wrote: > ...
3 years, 7 months ago (2017-05-10 19:06:30 UTC) #10
pdr.
https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp File third_party/WebKit/Source/core/frame/Settings.cpp (left): https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/core/frame/Settings.cpp#oldcode65 third_party/WebKit/Source/core/frame/Settings.cpp:65: : text_autosizing_window_size_override_(320, 480), On 2017/05/10 at 19:06:30, Nico wrote: ...
3 years, 7 months ago (2017-05-10 19:32:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874783003/1
3 years, 7 months ago (2017-05-10 19:35:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450796)
3 years, 7 months ago (2017-05-10 22:34:33 UTC) #16
pdr.
On 2017/05/10 at 22:34:33, commit-bot wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng ...
3 years, 7 months ago (2017-05-10 23:28:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874783003/1
3 years, 7 months ago (2017-05-10 23:29:16 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450997)
3 years, 7 months ago (2017-05-11 00:41:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874783003/1
3 years, 7 months ago (2017-05-11 13:28:18 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451723)
3 years, 7 months ago (2017-05-11 15:26:19 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874783003/1
3 years, 7 months ago (2017-05-11 15:27:52 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451898)
3 years, 7 months ago (2017-05-11 16:58:04 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874783003/1
3 years, 7 months ago (2017-05-11 17:00:01 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/442191)
3 years, 7 months ago (2017-05-11 19:59:00 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874783003/1
3 years, 7 months ago (2017-05-11 20:04:25 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:28:15 UTC) #38
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6aa511064b40136b0bf83d92669...

Powered by Google App Engine
This is Rietveld 408576698