|
|
DescriptionRemove DEBUG_TEXT_AUTOSIZING_ON_DESKTOP altogether.
Autosizing can be triggered through devtools on desktop nowadays.
BUG=675877
Review-Url: https://codereview.chromium.org/2874783003
Cr-Commit-Position: refs/heads/master@{#471090}
Committed: https://chromium.googlesource.com/chromium/src/+/c6aa511064b40136b0bf83d926690898b285f114
Patch Set 1 #
Total comments: 3
Messages
Total messages: 38 (21 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + pdr@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/frame/Settings.cpp (left): https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/frame/Settings.cpp:65: : text_autosizing_window_size_override_(320, 480), I think we need to fully remove text_autosizing_window_size_override_ with this patch
https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/frame/Settings.cpp (left): https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/frame/Settings.cpp:65: : text_autosizing_window_size_override_(320, 480), On 2017/05/10 19:01:16, pdr. wrote: > I think we need to fully remove text_autosizing_window_size_override_ with this > patch It's used in a few (not many) tests, e.g. https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/text... , https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/tests/Text... – should those tests go away too?
https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/frame/Settings.cpp (left): https://codereview.chromium.org/2874783003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/frame/Settings.cpp:65: : text_autosizing_window_size_override_(320, 480), On 2017/05/10 at 19:06:30, Nico wrote: > On 2017/05/10 19:01:16, pdr. wrote: > > I think we need to fully remove text_autosizing_window_size_override_ with this > > patch > > It's used in a few (not many) tests, e.g. https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/text... , https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/tests/Text... – should those tests go away too? Oohh, that's right. I forgot how those tests work. We do want to keep those tests. LGTM to land as-is.
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2017/05/10 at 22:34:33, commit-bot wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) This bot just cleared up. Marking for CQ again.
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494533009215800, "parent_rev": "df9f27f551ca5f0686aea37ed459a03b35a7c9b5", "commit_rev": "c6aa511064b40136b0bf83d926690898b285f114"}
Message was sent while issue was closed.
Description was changed from ========== Remove DEBUG_TEXT_AUTOSIZING_ON_DESKTOP altogether. Autosizing can be triggered through devtools on desktop nowadays. BUG=675877 ========== to ========== Remove DEBUG_TEXT_AUTOSIZING_ON_DESKTOP altogether. Autosizing can be triggered through devtools on desktop nowadays. BUG=675877 Review-Url: https://codereview.chromium.org/2874783003 Cr-Commit-Position: refs/heads/master@{#471090} Committed: https://chromium.googlesource.com/chromium/src/+/c6aa511064b40136b0bf83d92669... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c6aa511064b40136b0bf83d92669... |