Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2874783002: Move kLockIcon into ui/vector_icons. (Closed)

Created:
3 years, 7 months ago by cjgrant
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tfarina, feature-vr-reviews_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move kLockIcon into ui/vector_icons. This lets the VR browser implementation reuse the icon. BUG=715713 Review-Url: https://codereview.chromium.org/2874783002 Cr-Commit-Position: refs/heads/master@{#470933} Committed: https://chromium.googlesource.com/chromium/src/+/c9b407921cba4872404e21ac42b6ece033dcf406

Patch Set 1 #

Patch Set 2 : Add a dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -38 lines) Patch
M chrome/app/vector_icons/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/app/vector_icons/lock.icon View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/vector_icons/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + ui/vector_icons/lock.icon View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
cjgrant
estade@chromium.org: Please review changes in - chrome/app/ - ui/ pkasting@chromium.org: Please review changes in: - ...
3 years, 7 months ago (2017-05-10 15:36:02 UTC) #4
Evan Stade
lgtm
3 years, 7 months ago (2017-05-10 15:54:53 UTC) #5
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-10 20:38:46 UTC) #8
mthiesse
lgtm
3 years, 7 months ago (2017-05-11 00:36:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874783002/20001
3 years, 7 months ago (2017-05-11 12:38:48 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 12:43:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9b407921cba4872404e21ac42b6...

Powered by Google App Engine
This is Rietveld 408576698