Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2874773003: [css-align] Fixed errors place-self parsing tests (Closed)

Created:
3 years, 7 months ago by jfernandez
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-align] Fixed errors place-self parsing tests The place-self parsing regression tests are incorrect as they were using place-items property instead. BUG=668639 Review-Url: https://codereview.chromium.org/2874773003 Cr-Commit-Position: refs/heads/master@{#470867} Committed: https://chromium.googlesource.com/chromium/src/+/cb4e6a04496ddfff77976950c620fb3448abcd96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -149 lines) Patch
M third_party/WebKit/LayoutTests/fast/alignment/parse-place-self.html View 2 chunks +147 lines, -149 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
jfernandez
PTAL
3 years, 7 months ago (2017-05-10 12:37:16 UTC) #2
Manuel Rego
Wow, nice catch. LGTM :-) Could you add BUG=XXXXX linking to the bug where the ...
3 years, 7 months ago (2017-05-10 12:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874773003/1
3 years, 7 months ago (2017-05-10 12:54:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450011)
3 years, 7 months ago (2017-05-10 14:01:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874773003/1
3 years, 7 months ago (2017-05-10 14:30:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450085)
3 years, 7 months ago (2017-05-10 15:53:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874773003/1
3 years, 7 months ago (2017-05-11 07:06:41 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 08:03:35 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb4e6a04496ddfff77976950c620...

Powered by Google App Engine
This is Rietveld 408576698