Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2874773002: Add feature to control showing suggestion summaries. (Closed)

Created:
3 years, 7 months ago by Michael van Ouwerkerk
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add feature to control showing suggestion summaries. BUG=720288 Review-Url: https://codereview.chromium.org/2874773002 Cr-Commit-Position: refs/heads/master@{#470569} Committed: https://chromium.googlesource.com/chromium/src/+/6771b159ea1b5c67fb573d6b88c90b7b29550f52

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : Add entries to enums.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
3 years, 7 months ago (2017-05-10 11:02:41 UTC) #3
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-10 14:25:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874773002/40001
3 years, 7 months ago (2017-05-10 14:26:56 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 14:40:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6771b159ea1b5c67fb573d6b88c9...

Powered by Google App Engine
This is Rietveld 408576698