Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 287473002: rename rebaseline_server JSON constants to be more consistent (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rename rebaseline_server JSON constants to be more consistent (no behavioral change, no change to JSON file format) (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14701

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -191 lines) Patch
M gm/rebaseline_server/column.py View 1 chunk +0 lines, -1 line 1 comment Download
M gm/rebaseline_server/compare_configs.py View 2 chunks +6 lines, -6 lines 0 comments Download
M gm/rebaseline_server/compare_rendered_pictures.py View 3 chunks +7 lines, -7 lines 0 comments Download
M gm/rebaseline_server/compare_to_expectations.py View 5 chunks +22 lines, -22 lines 0 comments Download
M gm/rebaseline_server/imagediffdb.py View 2 chunks +10 lines, -10 lines 0 comments Download
M gm/rebaseline_server/imagepair.py View 2 chunks +14 lines, -13 lines 0 comments Download
M gm/rebaseline_server/imagepairset.py View 2 chunks +8 lines, -5 lines 0 comments Download
M gm/rebaseline_server/imagepairset_test.py View 2 chunks +16 lines, -16 lines 0 comments Download
M gm/rebaseline_server/results.py View 4 chunks +8 lines, -10 lines 0 comments Download
M gm/rebaseline_server/server.py View 2 chunks +4 lines, -3 lines 0 comments Download
M gm/rebaseline_server/static/constants.js View 4 chunks +24 lines, -21 lines 1 comment Download
M gm/rebaseline_server/static/loader.js View 9 chunks +37 lines, -37 lines 0 comments Download
M gm/rebaseline_server/static/view.html View 15 chunks +40 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
PTAL. https://codereview.chromium.org/287473002/diff/1/gm/rebaseline_server/column.py File gm/rebaseline_server/column.py (left): https://codereview.chromium.org/287473002/diff/1/gm/rebaseline_server/column.py#oldcode14 gm/rebaseline_server/column.py:14: KEY__EXTRACOLUMNHEADERS = 'extraColumnHeaders' Some of the constant definitions ...
6 years, 7 months ago (2014-05-12 19:17:07 UTC) #1
epoger
The trybot failure is due to http://skbug.com/2541 ('RunDM failing on http://108.170.220.102:10117/builders/Housekeeper-PerCommit') , not this CL.
6 years, 7 months ago (2014-05-12 19:41:29 UTC) #2
rmistry
LGTM
6 years, 7 months ago (2014-05-12 20:37:06 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-05-12 20:39:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/287473002/1
6 years, 7 months ago (2014-05-12 20:40:07 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 20:40:45 UTC) #6
Message was sent while issue was closed. 
Change committed as 14701

Powered by Google App Engine
This is Rietveld 408576698