Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: gm/rebaseline_server/compare_configs.py

Issue 287473002: rename rebaseline_server JSON constants to be more consistent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/compare_configs.py
diff --git a/gm/rebaseline_server/compare_configs.py b/gm/rebaseline_server/compare_configs.py
index e84de9ae159d14b8e82318de39406b6eae8b2d25..aa26ba6f3740582db892533448739860bb291b71 100755
--- a/gm/rebaseline_server/compare_configs.py
+++ b/gm/rebaseline_server/compare_configs.py
@@ -101,13 +101,13 @@ class ConfigComparisons(results.BaseComparisons):
diff_base_url=self._diff_base_url)
all_image_pairs.ensure_extra_column_values_in_summary(
- column_id=results.KEY__EXTRACOLUMN__RESULT_TYPE, values=[
+ column_id=results.KEY__EXTRACOLUMNS__RESULT_TYPE, values=[
results.KEY__RESULT_TYPE__FAILED,
results.KEY__RESULT_TYPE__NOCOMPARISON,
results.KEY__RESULT_TYPE__SUCCEEDED,
])
failing_image_pairs.ensure_extra_column_values_in_summary(
- column_id=results.KEY__EXTRACOLUMN__RESULT_TYPE, values=[
+ column_id=results.KEY__EXTRACOLUMNS__RESULT_TYPE, values=[
results.KEY__RESULT_TYPE__FAILED,
results.KEY__RESULT_TYPE__NOCOMPARISON,
])
@@ -155,13 +155,13 @@ class ConfigComparisons(results.BaseComparisons):
result_type = results.KEY__RESULT_TYPE__FAILED
extra_columns_dict = {
- results.KEY__EXTRACOLUMN__RESULT_TYPE: result_type,
- results.KEY__EXTRACOLUMN__BUILDER: builder,
- results.KEY__EXTRACOLUMN__TEST: test,
+ results.KEY__EXTRACOLUMNS__RESULT_TYPE: result_type,
+ results.KEY__EXTRACOLUMNS__BUILDER: builder,
+ results.KEY__EXTRACOLUMNS__TEST: test,
# TODO(epoger): Right now, the client UI crashes if it receives
# results that do not include a 'config' column.
# Until we fix that, keep the client happy.
- results.KEY__EXTRACOLUMN__CONFIG: 'TODO',
+ results.KEY__EXTRACOLUMNS__CONFIG: 'TODO',
}
try:

Powered by Google App Engine
This is Rietveld 408576698