Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2874713003: [turbofan] Reland of `Add alignment parameter to StackSlot operator` (Closed)

Created:
3 years, 7 months ago by ivica.bogosavljevic
Modified:
3 years, 7 months ago
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reland of `Add alignment parameter to StackSlot operator` Reland d8bfdb7a998adadc56aa5705a5998e75ceae7675 Original commit message: If alignment parameter is set, the memory returned by the StackSlot operator will be aligned according to the parameter. The implementation goes like this. If alignment parameter is set we allocate a bit more memory than actually needed and so we can move the beginning of the StackSlot in order to have it aligned. BUG= Review-Url: https://codereview.chromium.org/2874713003 Cr-Commit-Position: refs/heads/master@{#45339} Committed: https://chromium.googlesource.com/v8/v8/+/4a5adb43accbdf38baa81915871470890cfe1248

Patch Set 1 : Original commit that caused the failure #

Patch Set 2 : Fix failures with control flow integrity bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -55 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/frame.h View 1 chunk +11 lines, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +25 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.cc View 4 chunks +47 lines, -24 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +29 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +29 lines, -2 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
ivica.bogosavljevic
The original CL got reverted because of the failure in Control Flow Integrity buildbots https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/9989 ...
3 years, 7 months ago (2017-05-11 10:59:13 UTC) #2
Clemens Hammacher
lgtm
3 years, 7 months ago (2017-05-11 11:08:16 UTC) #3
ahaas
lgtm
3 years, 7 months ago (2017-05-11 11:15:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713003/20001
3 years, 7 months ago (2017-05-11 12:06:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40882)
3 years, 7 months ago (2017-05-11 12:09:29 UTC) #12
ivica.bogosavljevic
I need lgtm from the owner of the compiler directory
3 years, 7 months ago (2017-05-11 12:54:05 UTC) #13
ivica.bogosavljevic
ping
3 years, 7 months ago (2017-05-16 07:45:23 UTC) #14
Benedikt Meurer
LGTM (rubber-stamped)
3 years, 7 months ago (2017-05-16 08:27:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713003/20001
3 years, 7 months ago (2017-05-16 11:57:14 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 12:28:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4a5adb43accbdf38baa81915871470890cf...

Powered by Google App Engine
This is Rietveld 408576698