Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2874713002: Move many standalone files from web/ to (core|modules)/exported/. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, kinuko+watch, kinuko+fileapi, mlamouri+watch-blink_chromium.org, nhiroki, Srirama, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move many standalone files from web/ to (core|modules)/exported/. This CL starts moving files from web/ that are implementations of classes defined in public/web/ that have no other dependencies in web/. Classes that have some dependency on modules/ move to modules/exported/, otherwise classes move to core/exported. This required setting up the modules/exported directory and BUILD file, and now exposing WebKit/Source/modules via the blink_all build rule so that the symbols are available. In some cases this also required adding BLINK_EXPORT to some of the definitions in public/web/, but these are all inside of BLINK_IMPLEMENTATION blocks which indicates that there should be no dependence on these methods externally. BUG=712963 Review-Url: https://codereview.chromium.org/2874713002 Cr-Commit-Position: refs/heads/master@{#470910} Committed: https://chromium.googlesource.com/chromium/src/+/44395608981a4f8ee6b25f048d69e68cd7b8498a

Patch Set 1 #

Patch Set 2 : Fix type. #

Patch Set 3 : Removed unused import. #

Patch Set 4 : Use NON_EXPORTED_BASE for WebFileCHooserCompletion. #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1005 lines) Patch
M third_party/WebKit/Source/core/exported/BUILD.gn View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebCSSParser.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebColorSuggestion.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebCustomElement.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebDOMActivityLogger.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebDOMEvent.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebDateTimeSuggestion.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebFileChooserCompletionImpl.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/core/exported/WebFileChooserCompletionImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/exported/WebHeap.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebImageCache.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/exported/WebImageDecoder.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/exported/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/exported/WebCryptoNormalize.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/exported/WebDOMFileSystem.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/exported/WebDOMMediaStreamTrack.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/exported/WebDatabase.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 3 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/web/WebCSSParser.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/web/WebColorSuggestion.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/web/WebCryptoNormalize.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/web/WebCustomElement.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/web/WebDOMActivityLogger.cpp View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/Source/web/WebDOMEvent.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/web/WebDOMFileSystem.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/WebKit/Source/web/WebDOMMediaStreamTrack.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/Source/web/WebDatabase.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/web/WebDateTimeSuggestion.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/web/WebFileChooserCompletionImpl.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/web/WebFileChooserCompletionImpl.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/Source/web/WebHeap.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/web/WebImageCache.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/web/WebImageDecoder.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebColorSuggestion.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebDOMEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebDateTimeSuggestion.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (19 generated)
slangley
3 years, 7 months ago (2017-05-10 03:42:06 UTC) #5
haraken
LGTM
3 years, 7 months ago (2017-05-10 04:09:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713002/40001
3 years, 7 months ago (2017-05-10 04:17:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/422564)
3 years, 7 months ago (2017-05-10 05:11:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713002/80001
3 years, 7 months ago (2017-05-10 06:20:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449720)
3 years, 7 months ago (2017-05-10 09:10:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713002/80001
3 years, 7 months ago (2017-05-10 09:18:26 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449795)
3 years, 7 months ago (2017-05-10 11:28:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713002/80001
3 years, 7 months ago (2017-05-10 21:59:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713002/80001
3 years, 7 months ago (2017-05-10 22:01:27 UTC) #23
commit-bot: I haz the power
Exhausted attempt retry quota accross all builders (set as global_retry_quota=2 in cq.cfg of this project)
3 years, 7 months ago (2017-05-11 00:26:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713002/80001
3 years, 7 months ago (2017-05-11 05:47:19 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/423857)
3 years, 7 months ago (2017-05-11 07:44:16 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874713002/80001
3 years, 7 months ago (2017-05-11 08:34:45 UTC) #31
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 10:49:06 UTC) #34
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/44395608981a4f8ee6b25f048d69...

Powered by Google App Engine
This is Rietveld 408576698