Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2874703002: base: employ ReadSymbolicLink() in PathProviderAndroid() (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

base: employ ReadSymbolicLink() in PathProviderAndroid() Makes this code path consistent with the same one in PathProviderPosix. BUG=None TEST=base_unittests R=dcheng@chromium.org Review-Url: https://codereview.chromium.org/2874703002 Cr-Commit-Position: refs/heads/master@{#470661} Committed: https://chromium.googlesource.com/chromium/src/+/0cead9c8ed144d45719a31b648d44ccb487f1f3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M base/base_paths_android.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tfarina
3 years, 7 months ago (2017-05-10 13:07:59 UTC) #5
dcheng
LGTM But please update the CL description to include motivation: I assume this is just ...
3 years, 7 months ago (2017-05-10 17:29:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874703002/1
3 years, 7 months ago (2017-05-10 18:45:12 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 18:56:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0cead9c8ed144d45719a31b648d4...

Powered by Google App Engine
This is Rietveld 408576698