Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2874683002: vpython: Version parser from PEP440. (Closed)

Created:
3 years, 7 months ago by dnj
Modified:
3 years, 7 months ago
Reviewers:
dnj (Google), iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

vpython: Version parser from PEP440. Use canonical version regexp from PEP440 instead of crude "major.minor.patch" version parsing. We still parse into the previous form, but we tolerate the full set of canonical strings. This is in response to observed "2.7.13+" in the wild. BUG=None TEST=unit Review-Url: https://codereview.chromium.org/2874683002 Committed: https://github.com/luci/luci-go/commit/0eb69ab195d7c4a88cd41d26b53f9a868c15713f

Patch Set 1 #

Total comments: 1

Patch Set 2 : stronger test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -37 lines) Patch
M vpython/python/python_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M vpython/python/version.go View 3 chunks +40 lines, -29 lines 0 comments Download
M vpython/python/version_test.go View 1 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dnj (Google)
PTAL
3 years, 7 months ago (2017-05-10 04:10:32 UTC) #2
iannucci
lgtm https://codereview.chromium.org/2874683002/diff/1/vpython/python/version_test.go File vpython/python/version_test.go (right): https://codereview.chromium.org/2874683002/diff/1/vpython/python/version_test.go#newcode39 vpython/python/version_test.go:39: {"1!1.0", Version{1, 0, 0}}, 2!1.0
3 years, 7 months ago (2017-05-10 19:43:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874683002/20001
3 years, 7 months ago (2017-05-10 21:42:19 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 21:49:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/0eb69ab195d7c4a88cd41d26b53f9a868c15713f

Powered by Google App Engine
This is Rietveld 408576698