Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2874673002:
Fix flakiness of message_center_unittests in mac (Closed)
DescriptionFix flakiness of message_center_unittests in mac
BUG=720007
Review-Url: https://codereview.chromium.org/2874673002
Cr-Commit-Position: refs/heads/master@{#470764}
Committed: https://chromium.googlesource.com/chromium/src/+/9880581d62ccb38559e5d8503c802e78c414ef22
Patch Set 1 #Patch Set 2 : . #
Total comments: 1
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== . BUG= ========== to ========== Fix flakiness of message_center_unittests in mac BUG=720007 ==========
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
yoshiki@chromium.org changed reviewers: + yhanada@chromium.org
Hanada-san, PTAL.
https://codereview.chromium.org/2874673002/diff/20001/ui/message_center/messa... File ui/message_center/message_center_impl_unittest.cc (left): https://codereview.chromium.org/2874673002/diff/20001/ui/message_center/messa... ui/message_center/message_center_impl_unittest.cc:319: base::TimeDelta::FromMilliseconds(1)); Should this be changed to TimeDelta::FromMilliseconds(0) to ensure that this timer finishes?
On 2017/05/10 09:32:10, yhanada wrote: > https://codereview.chromium.org/2874673002/diff/20001/ui/message_center/messa... > File ui/message_center/message_center_impl_unittest.cc (left): > > https://codereview.chromium.org/2874673002/diff/20001/ui/message_center/messa... > ui/message_center/message_center_impl_unittest.cc:319: > base::TimeDelta::FromMilliseconds(1)); > Should this be changed to TimeDelta::FromMilliseconds(0) to ensure that this > timer finishes? Ah, I misunderstood this value. lgtm
thanks!
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494463039924470,
"parent_rev": "5b77a9f9f65b2e778256fe219c5fc1d257565066", "commit_rev":
"9880581d62ccb38559e5d8503c802e78c414ef22"}
Message was sent while issue was closed.
Description was changed from ========== Fix flakiness of message_center_unittests in mac BUG=720007 ========== to ========== Fix flakiness of message_center_unittests in mac BUG=720007 Review-Url: https://codereview.chromium.org/2874673002 Cr-Commit-Position: refs/heads/master@{#470764} Committed: https://chromium.googlesource.com/chromium/src/+/9880581d62ccb38559e5d8503c80... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9880581d62ccb38559e5d8503c80... |
