Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
index 89aff1432063326d9d4efab8fb9ad03f53c9be66..3dbc12450c1a8a4fada3748a7fc94ae9d594f058 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
@@ -15,7 +15,8 @@ class AbortsPageLoadMetricsObserverTest
}
void SimulateTimingWithoutPaint() {
- page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::mojom::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1);
SimulateTimingUpdate(timing);
}
@@ -244,9 +245,10 @@ TEST_F(AbortsPageLoadMetricsObserverTest,
}
TEST_F(AbortsPageLoadMetricsObserverTest, NoAbortNewNavigationAfterPaint) {
- page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::mojom::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1);
- timing.paint_timing.first_paint = base::TimeDelta::FromMicroseconds(1);
+ timing.paint_timing->first_paint = base::TimeDelta::FromMicroseconds(1);
PopulateRequiredTimingFields(&timing);
NavigateAndCommit(GURL("https://www.google.com"));
SimulateTimingUpdate(timing);

Powered by Google App Engine
This is Rietveld 408576698