Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5240)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 48a9bc06c278f7d840147c3c57088d921fee846e..9021acc71bf0ae35e4f96a36da66c9d4888de587 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -296,7 +296,7 @@ bool ShouldTrackMetrics(const page_load_metrics::PageLoadExtraInfo& extra_info,
AbortsPageLoadMetricsObserver::AbortsPageLoadMetricsObserver() {}
void AbortsPageLoadMetricsObserver::OnComplete(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
page_load_metrics::PageAbortInfo abort_info = GetPageAbortInfo(extra_info);
if (!ShouldTrackMetrics(extra_info, abort_info))
@@ -309,17 +309,17 @@ void AbortsPageLoadMetricsObserver::OnComplete(
// timing IPCs are tracked via the ERR_NO_IPCS_RECEIVED error code in the
// PageLoad.Events.InternalError histogram, so we can keep track of how often
// this happens.
- if (timing.IsEmpty())
+ if (page_load_metrics::IsEmpty(timing))
return;
- if (timing.parse_timing.parse_start &&
- abort_info.time_to_abort >= timing.parse_timing.parse_start &&
- (!timing.parse_timing.parse_stop ||
- timing.parse_timing.parse_stop >= abort_info.time_to_abort)) {
+ if (timing.parse_timing->parse_start &&
+ abort_info.time_to_abort >= timing.parse_timing->parse_start &&
+ (!timing.parse_timing->parse_stop ||
+ timing.parse_timing->parse_stop >= abort_info.time_to_abort)) {
RecordAbortDuringParse(abort_info);
}
- if (!timing.paint_timing.first_paint ||
- timing.paint_timing.first_paint >= abort_info.time_to_abort) {
+ if (!timing.paint_timing->first_paint ||
+ timing.paint_timing->first_paint >= abort_info.time_to_abort) {
RecordAbortAfterCommitBeforePaint(abort_info);
}
}

Powered by Google App Engine
This is Rietveld 408576698