Add the metric to record percentage improvement for parallel download.

Add the metric to record  percentage improvement for parallel download.

Records the ratio of bandwidth of parallel streams to the bandwidth of
single stream, and the ratio of total time to download a file with
parallel streams bandwidth to the actual total time.

BUG=720168
Review-Url: https://codereview.chromium.org/2874603002
Cr-Commit-Position: refs/heads/master@{#471608}
Committed: https://chromium.googlesource.com/chromium/src/+/a672d19ad76be908d9339fe093f88fd1e66b99f8

[xingliu, 2017-05-10 01:10:54]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, qinmin@chromium.org

[xingliu, 2017-05-10 01:10:55]

Hi, PTAL, thanks.

[xingliu, 2017-05-10 01:10:59]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:12:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:14:59]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[qinmin, 2017-05-10 18:46:47]

https://codereview.chromium.org/2874603002/diff/20001/content/browser/downloa...
File content/browser/download/download_stats.cc (right):

https://codereview.chromium.org/2874603002/diff/20001/content/browser/downloa...
content/browser/download/download_stats.cc:841: int time_ratio_percentage =
This doesn't seem right.
When we say that parallel download improves the download time, shouldn't we
compare actual download time with the theoretical download time without parallel
requests?

So it should be total_time/(total_size/bandwidth_without_parallel_streams)?

[xingliu, 2017-05-10 20:08:06]

Thanks for the review.

https://codereview.chromium.org/2874603002/diff/20001/content/browser/downloa...
File content/browser/download/download_stats.cc (right):

https://codereview.chromium.org/2874603002/diff/20001/content/browser/downloa...
content/browser/download/download_stats.cc:841: int time_ratio_percentage =
On 2017/05/10 18:46:47, qinmin wrote:
> This doesn't seem right.
> When we say that parallel download improves the download time, shouldn't we
> compare actual download time with the theoretical download time without
parallel
> requests?
> 
> So it should be total_time/(total_size/bandwidth_without_parallel_streams)?

Done. Makes sense.

[xingliu, 2017-05-10 21:07:31]

xingliu@chromium.org changed reviewers:
+ isherman@chromium.org

[xingliu, 2017-05-10 21:07:32]

+isherman for histogram review, thanks.

[Ilya Sherman, 2017-05-11 00:46:52]

Metrics LGTM

[qinmin, 2017-05-12 18:43:52]

lgtm

[xingliu, 2017-05-13 00:16:02]

The CQ bit was checked by xingliu@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:16:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:21:09]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xingliu, 2017-05-13 02:14:35]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2017-05-13 02:14:36]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2874603002/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-05-13 02:15:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 02:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 02:50:43]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xingliu, 2017-05-13 20:55:36]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 20:55:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 21:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 21:50:58]

Dry run: This issue passed the CQ dry run.

[xingliu, 2017-05-13 21:59:15]

The CQ bit was checked by xingliu@chromium.org

[commit-bot: I haz the power, 2017-05-13 21:59:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 22:04:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494712755441330,
"parent_rev": "08b54572d6f67b8a90cf28e2fca44f19071993d8", "commit_rev":
"a672d19ad76be908d9339fe093f88fd1e66b99f8"}

[commit-bot: I haz the power, 2017-05-13 22:04:35]

Description was changed from

==========
Add the metric to record  percentage improvement for parallel download.

Records the ratio of bandwidth of parallel streams to the bandwidth of
single stream, and the ratio of total time to download a file with
parallel streams bandwidth to the actual total time.

BUG=720168
==========

to

==========
Add the metric to record  percentage improvement for parallel download.

Records the ratio of bandwidth of parallel streams to the bandwidth of
single stream, and the ratio of total time to download a file with
parallel streams bandwidth to the actual total time.

BUG=720168

Review-Url: https://codereview.chromium.org/2874603002
Cr-Commit-Position: refs/heads/master@{#471608}
Committed:
https://chromium.googlesource.com/chromium/src/+/a672d19ad76be908d9339fe093f8...
==========

[commit-bot: I haz the power, 2017-05-13 22:04:37]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a672d19ad76be908d9339fe093f8...