Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4748)

Unified Diff: chrome/android/java/res/menu/download_manager_menu.xml

Issue 2874563002: Download home : Added info menu icon (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/menu/download_manager_menu.xml
diff --git a/chrome/android/java/res/menu/download_manager_menu.xml b/chrome/android/java/res/menu/download_manager_menu.xml
index 313c5eaac552ccf9717b60c0e609ffc27a55af65..a677e7ae2bd90b8123601996dcac3830935051c8 100644
--- a/chrome/android/java/res/menu/download_manager_menu.xml
+++ b/chrome/android/java/res/menu/download_manager_menu.xml
@@ -7,6 +7,12 @@
xmlns:chrome="http://schemas.android.com/apk/res-auto" >
<group android:id="@+id/normal_menu_group" >
+ <item
+ android:id="@+id/info_menu_id"
+ android:icon="@drawable/btn_info"
+ android:title="@string/info"
Theresa 2017/05/09 23:32:23 The title is used as fallback when there's not roo
Theresa 2017/05/10 00:05:44 Another potential is "Show info" and "Hide info",
shaktisahu 2017/05/11 19:55:47 While waiting on an updated string request, I have
+ android:visible="false"
+ chrome:showAsAction="ifRoom" />
<item
android:id="@+id/search_menu_id"
android:icon="@drawable/ic_search"

Powered by Google App Engine
This is Rietveld 408576698