Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2016 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <menu xmlns:android="http://schemas.android.com/apk/res/android" | 6 <menu xmlns:android="http://schemas.android.com/apk/res/android" |
| 7 xmlns:chrome="http://schemas.android.com/apk/res-auto" > | 7 xmlns:chrome="http://schemas.android.com/apk/res-auto" > |
| 8 | 8 |
| 9 <group android:id="@+id/normal_menu_group" > | 9 <group android:id="@+id/normal_menu_group" > |
| 10 <item | 10 <item |
| 11 android:id="@+id/info_menu_id" | |
| 12 android:icon="@drawable/btn_info" | |
| 13 android:title="@string/info" | |
|
Theresa
2017/05/09 23:32:23
The title is used as fallback when there's not roo
Theresa
2017/05/10 00:05:44
Another potential is "Show info" and "Hide info",
shaktisahu
2017/05/11 19:55:47
While waiting on an updated string request, I have
| |
| 14 android:visible="false" | |
| 15 chrome:showAsAction="ifRoom" /> | |
| 16 <item | |
| 11 android:id="@+id/search_menu_id" | 17 android:id="@+id/search_menu_id" |
| 12 android:icon="@drawable/ic_search" | 18 android:icon="@drawable/ic_search" |
| 13 android:title="@string/search" | 19 android:title="@string/search" |
| 14 android:visible="false" | 20 android:visible="false" |
| 15 chrome:showAsAction="ifRoom" /> | 21 chrome:showAsAction="ifRoom" /> |
| 16 <item | 22 <item |
| 17 android:id="@+id/close_menu_id" | 23 android:id="@+id/close_menu_id" |
| 18 android:icon="@drawable/btn_close" | 24 android:icon="@drawable/btn_close" |
| 19 android:title="@string/close" | 25 android:title="@string/close" |
| 20 chrome:showAsAction="ifRoom" /> | 26 chrome:showAsAction="ifRoom" /> |
| 21 </group> | 27 </group> |
| 22 <group | 28 <group |
| 23 android:id="@+id/selection_mode_menu_group" | 29 android:id="@+id/selection_mode_menu_group" |
| 24 android:visible="false" > | 30 android:visible="false" > |
| 25 <item | 31 <item |
| 26 android:id="@+id/selection_mode_share_menu_id" | 32 android:id="@+id/selection_mode_share_menu_id" |
| 27 android:icon="@drawable/ic_share_white_24dp" | 33 android:icon="@drawable/ic_share_white_24dp" |
| 28 android:title="@string/share" | 34 android:title="@string/share" |
| 29 chrome:showAsAction="ifRoom" /> | 35 chrome:showAsAction="ifRoom" /> |
| 30 <item | 36 <item |
| 31 android:id="@+id/selection_mode_delete_menu_id" | 37 android:id="@+id/selection_mode_delete_menu_id" |
| 32 android:icon="@drawable/ic_delete_white_24dp" | 38 android:icon="@drawable/ic_delete_white_24dp" |
| 33 android:title="@string/delete" | 39 android:title="@string/delete" |
| 34 chrome:showAsAction="ifRoom" /> | 40 chrome:showAsAction="ifRoom" /> |
| 35 </group> | 41 </group> |
| 36 </menu> | 42 </menu> |
| OLD | NEW |