Refactor CRX verification in preparation to support CRX₃ files.

extensions/browser/sandboxed_unpacker_unittest.cc

Index: extensions/browser/sandboxed_unpacker_unittest.cc
diff --git a/extensions/browser/sandboxed_unpacker_unittest.cc b/extensions/browser/sandboxed_unpacker_unittest.cc
index 8330efa65af7ccc574ba5ea2ecdb8bc7e19d5d0d..104e65b13102181263d7a944a269149bf2430b30 100644
--- a/extensions/browser/sandboxed_unpacker_unittest.cc
+++ b/extensions/browser/sandboxed_unpacker_unittest.cc
@@ -168,7 +168,9 @@ TEST_F(SandboxedUnpackerTest, FromDirWithCatalogsSuccess) {
 TEST_F(SandboxedUnpackerTest, FailHashCheck) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       extensions::switches::kEnableCrxHashCheck);
-  SetupUnpacker("good_l10n.crx", "badhash");
+  SetupUnpacker(
+      "good_l10n.crx",
+      "0000000000000000000000000000000000000000000000000000000000000000");

[Devlin, 2017/05/16 22:55:02]

I assume the fact that this is 64 characters is not a coincidence. :)  This
would be clearer (and shorter) as std::string(64, '0').

[waffles, 2017/05/17 17:18:22]

Done.

   // Check that there is an error message.
   EXPECT_NE(base::string16(), GetInstallError());
 }