Refactor CRX verification in preparation to support CRX₃ files.

extensions/browser/sandboxed_unpacker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/sandboxed_unpacker.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
@@ skipping 150 matching lines @@
 TEST_F(SandboxedUnpackerTest, FromDirWithCatalogsSuccess) {
   SetupUnpackerWithDirectory("good_l10n.crx");
   // Check that there is _locales folder.
   base::FilePath install_path = GetInstallPath().Append(kLocaleFolder);
   EXPECT_TRUE(base::PathExists(install_path));
 }
 
 TEST_F(SandboxedUnpackerTest, FailHashCheck) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       extensions::switches::kEnableCrxHashCheck);
-  SetupUnpacker("good_l10n.crx", "badhash");
+  SetupUnpacker(
+      "good_l10n.crx",
+      "0000000000000000000000000000000000000000000000000000000000000000");

[Devlin, 2017/05/16 22:55:02]

I assume the fact that this is 64 characters is not a coincidence. :)  This
would be clearer (and shorter) as std::string(64, '0').

[waffles, 2017/05/17 17:18:22]

Done.

   // Check that there is an error message.
   EXPECT_NE(base::string16(), GetInstallError());
 }
 
 TEST_F(SandboxedUnpackerTest, PassHashCheck) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       extensions::switches::kEnableCrxHashCheck);
   SetupUnpacker(
       "good_l10n.crx",
       "6fa171c726373785aa4fcd2df448c3db0420a95d5044fbee831f089b979c4068");
   // Check that there is no error message.
   EXPECT_EQ(base::string16(), GetInstallError());
 }
 
 TEST_F(SandboxedUnpackerTest, SkipHashCheck) {
   SetupUnpacker("good_l10n.crx", "badhash");
   // Check that there is no error message.
   EXPECT_EQ(base::string16(), GetInstallError());
 }
 
 }  // namespace extensions