Make ARC's intent picker use the buttons insets.

ui/views/window/dialog_client_view.cc

Index: ui/views/window/dialog_client_view.cc
diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc
index 775f54d9815b039505f80e17a8266c9091a481d9..e5b8a0b6f0de497bfccdbdb47bb02871a7b4abe8 100644
--- a/ui/views/window/dialog_client_view.cc
+++ b/ui/views/window/dialog_client_view.cc
@@ -108,6 +108,12 @@ void DialogClientView::UpdateDialogButtons() {
   InvalidateLayout();
 }
 
+void DialogClientView::SetButtonRowInsets(const gfx::Insets& insets) {
+  button_row_insets_ = insets;
+  if (button_row_container_->has_children())

[sky, 2017/05/14 16:01:16]

Why do you make this conditional on whether there are children? I could checking
if in a widget, but I'm not sure why the children matter.

[djacobo, 2017/05/16 01:10:25]

Initially I thought that not having an ok_button_ or cancel_button_ was the root
cause, (the observable behavior was the browser crashing right after logging
in), however, after some debugging I noticed that the real problem was
SetButtonRowInsets() being called from a view without a widget (which is a valid
case and that would still try to call
https://cs.chromium.org/chromium/src/ui/views/window/dialog_client_view.cc?dr...)

So I can replace line 113 with if (GetWidget()) and that should be enough,
replacing this line. Thanks for the pointer!

+    UpdateDialogButtons();
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // DialogClientView, ClientView overrides: