Make ARC's intent picker use the buttons insets.

ui/views/window/dialog_client_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/dialog_client_view.h"
 
 #include <algorithm>
 
 #include "build/build_config.h"
 #include "ui/base/material_design/material_design_controller.h"
@@ skipping 90 matching lines @@
     delegate_allowed_close_ = true;
     GetWidget()->Close();
   }
 }
 
 void DialogClientView::UpdateDialogButtons() {
   SetupLayout();
   InvalidateLayout();
 }
 
+void DialogClientView::SetButtonRowInsets(const gfx::Insets& insets) {
+  button_row_insets_ = insets;
+  if (button_row_container_->has_children())

[sky, 2017/05/14 16:01:16]

Why do you make this conditional on whether there are children? I could checking
if in a widget, but I'm not sure why the children matter.

[djacobo, 2017/05/16 01:10:25]

Initially I thought that not having an ok_button_ or cancel_button_ was the root
cause, (the observable behavior was the browser crashing right after logging
in), however, after some debugging I noticed that the real problem was
SetButtonRowInsets() being called from a view without a widget (which is a valid
case and that would still try to call
https://cs.chromium.org/chromium/src/ui/views/window/dialog_client_view.cc?dr...)

So I can replace line 113 with if (GetWidget()) and that should be enough,
replacing this line. Thanks for the pointer!

+    UpdateDialogButtons();
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // DialogClientView, ClientView overrides:
 
 bool DialogClientView::CanClose() {
   // If the dialog is closing but no Accept or Cancel action has been performed
   // before, it's a Close action.
   if (!delegate_allowed_close_)
     delegate_allowed_close_ = GetDialogDelegate()->Close();
   return delegate_allowed_close_;
 }
@@ skipping 300 matching lines @@
 
   if (extra_view_)
     return;
 
   extra_view_ = GetDialogDelegate()->CreateExtraView();
   if (extra_view_)
     extra_view_->SetGroup(kButtonGroup);
 }
 
 }  // namespace views