[Presentation API] Remove closed connections from PresentationConnectionList

[Presentation API] Remove closed connections from PresentationConnectionList

- Added WebPresentationReceiver::RemoveConnection() API
- Added WebPresentationReceiver pointer to ReceiverConnectionProxy. WebPresentationReceiver::RemoveConnection() is invoked when receiver connection changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, pass receiver_ pointer to ReceiverConnectionProxy

BUG=713227
Review-Url: https://codereview.chromium.org/2874483002
Cr-Commit-Position: refs/heads/master@{#473773}
Committed: https://chromium.googlesource.com/chromium/src/+/e17728ae5d18e371378473c0b4637940f95c3967

[zhaobin, 2017-05-09 20:32:34]

zhaobin@chromium.org changed reviewers:
+ mfoltz@chromium.org

[mark a. foltz, 2017-05-12 22:22:19]

Looks okay.  Instead of binding a callback, would it be simpler to pass
WebPresentationReceiver* to ReceiverConnectionProxy and call RemoveConnection()
directly?

https://codereview.chromium.org/2874483002/diff/1/content/renderer/presentati...
File content/renderer/presentation/presentation_connection_proxy.h (right):

https://codereview.chromium.org/2874483002/diff/1/content/renderer/presentati...
content/renderer/presentation/presentation_connection_proxy.h:120: //
|source_connection_| from blink PresentationReceiver's connection list.
nit: s/blink//

[zhaobin, 2017-05-15 17:46:03]

https://codereview.chromium.org/2874483002/diff/1/content/renderer/presentati...
File content/renderer/presentation/presentation_connection_proxy.h (right):

https://codereview.chromium.org/2874483002/diff/1/content/renderer/presentati...
content/renderer/presentation/presentation_connection_proxy.h:120: //
|source_connection_| from blink PresentationReceiver's connection list.
On 2017/05/12 22:22:19, mark a. foltz wrote:
> nit: s/blink//

Done.

[mark a. foltz, 2017-05-15 21:38:47]

lgtm

[mark a. foltz, 2017-05-15 21:39:20]

On 2017/05/15 21:38:47, mark a. foltz wrote:
> lgtm

Don't forget to update the CL description before committing :)

[zhaobin, 2017-05-16 18:09:21]

Description was changed from

==========
[Presentation API] Remove closed connections from PresentationConnectionList

- Added WebPresentationReceiver::RemoveConnection() API
- Added OnConnectionClosedCallback to ReceiverConnectionProxy. It is invoked
when receiver connection changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, bind receiver's
RemoveConnection() to ReceiverConnectionProxy's OnConnectionClosedCallback

BUG=713227
==========

to

==========
[Presentation API] Remove closed connections from PresentationConnectionList

- Added WebPresentationReceiver::RemoveConnection() API
- Added WebPresentationReceiver pointer to ReceiverConnectionProxy.
WebPresentationReceiver::RemoveConnection() is invoked when receiver connection
changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, pass receiver_
pointer to ReceiverConnectionProxy

BUG=713227
==========

[zhaobin, 2017-05-16 18:12:02]

On 2017/05/15 21:39:20, mark a. foltz wrote:
> On 2017/05/15 21:38:47, mark a. foltz wrote:
> > lgtm
> 
> Don't forget to update the CL description before committing :)

Done. CL description updated.

[zhaobin, 2017-05-18 19:04:57]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 19:05:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 01:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 01:17:52]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[zhaobin, 2017-05-22 21:05:29]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 21:05:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 22:56:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:56:46]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-05-23 01:12:40]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-05-23 01:12:41]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2874483002/#ps40001
(title: "rebase with master")

[commit-bot: I haz the power, 2017-05-23 01:13:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 01:19:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495501960425820,
"parent_rev": "9585ee5ebcc8de435e2901b857901c736b6c1e40", "commit_rev":
"e17728ae5d18e371378473c0b4637940f95c3967"}

[commit-bot: I haz the power, 2017-05-23 01:19:20]

Description was changed from

==========
[Presentation API] Remove closed connections from PresentationConnectionList

- Added WebPresentationReceiver::RemoveConnection() API
- Added WebPresentationReceiver pointer to ReceiverConnectionProxy.
WebPresentationReceiver::RemoveConnection() is invoked when receiver connection
changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, pass receiver_
pointer to ReceiverConnectionProxy

BUG=713227
==========

to

==========
[Presentation API] Remove closed connections from PresentationConnectionList

- Added WebPresentationReceiver::RemoveConnection() API
- Added WebPresentationReceiver pointer to ReceiverConnectionProxy.
WebPresentationReceiver::RemoveConnection() is invoked when receiver connection
changes to 'closed'
- In PresentationDispatcher::OnReceiverConnectionAvailable, pass receiver_
pointer to ReceiverConnectionProxy

BUG=713227

Review-Url: https://codereview.chromium.org/2874483002
Cr-Commit-Position: refs/heads/master@{#473773}
Committed:
https://chromium.googlesource.com/chromium/src/+/e17728ae5d18e371378473c0b463...
==========

[commit-bot: I haz the power, 2017-05-23 01:19:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e17728ae5d18e371378473c0b463...