Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2874463002:
avoid calling host() directly for imageBuffer on 2D rendenring contexts (Closed)
|
Created:
3 years, 7 months ago by fserb Modified:
3 years, 7 months ago Reviewers:
Justin Novosad CC:
blink-reviews, Rik, chromium-reviews, dshwang, haraken, Justin Novosad Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionavoid calling host() directly for imageBuffer on 2D rendenring contexts
Follow up from previous CRCHost changes. Clean up.
Notice that discardImageBuffer is still called directly.
BUG=720062
Review-Url: https://codereview.chromium.org/2874463002
Cr-Commit-Position: refs/heads/master@{#470842}
Committed: https://chromium.googlesource.com/chromium/src/+/0079e522b9b0a4971ff73ca7b12b14f709f3c87b
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 37 (20 generated)
fserb@chromium.org changed reviewers: + junov@chromium.org
The CQ bit was checked by fserb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
lgtm
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fserb@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494476942561930, "parent_rev":
"af845ca2180c1dc10b738130469aeff3efcc05b8", "commit_rev":
"0079e522b9b0a4971ff73ca7b12b14f709f3c87b"}
Message was sent while issue was closed.
Description was changed from ========== avoid calling host() directly for imageBuffer on 2D rendenring contexts Follow up from previous CRCHost changes. Clean up. Notice that discardImageBuffer is still called directly. BUG=720062 ========== to ========== avoid calling host() directly for imageBuffer on 2D rendenring contexts Follow up from previous CRCHost changes. Clean up. Notice that discardImageBuffer is still called directly. BUG=720062 Review-Url: https://codereview.chromium.org/2874463002 Cr-Commit-Position: refs/heads/master@{#470842} Committed: https://chromium.googlesource.com/chromium/src/+/0079e522b9b0a4971ff73ca7b12b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0079e522b9b0a4971ff73ca7b12b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
