[csa] Add ToLength and ToString variants with inlined fast checks

[csa] Add ToLength and ToString variants with inlined fast checks

Smis can easily be handled outside the stub call without adding much to code
size.

The ToString inlining adds overhead of repeated instance type loads and checks,
but under the assumption that it is called with mostly string values it should
speed things up (a local RegExp.p[@@replace] microbenchmark shows consistent
1.6% improvements).

Drive-by-fix: Remove duplication in ToString implementations.

BUG=

Review-Url: https://codereview.chromium.org/2874423003
Cr-Commit-Position: refs/heads/master@{#45287}
Committed: https://chromium.googlesource.com/v8/v8/+/646fdacaa790fa29f0a7224a513c6514ecb9f627

[jgruber, 2017-05-12 11:58:15]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 11:58:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 12:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 12:34:35]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-05-12 13:54:44]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 13:54:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-05-12 13:57:18]

Description was changed from

==========
[csa] Add ToLength variant with inlined fast checks

Smis can easily be handled outside the stub call without adding much to code
size.

BUG=
==========

to

==========
[csa] Add ToLength and ToString variants with inlined fast checks

Smis can easily be handled outside the stub call without adding much to code
size.

The ToString inlining adds overhead of repeated instance type loads and checks,
but under the assumption that it is called with mostly string values it should
speed things up (a local RegExp.p[@@replace] microbenchmark shows consistent
1.6% improvements).

BUG=
==========

[jgruber, 2017-05-12 13:57:18]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org

[jgruber, 2017-05-12 13:58:10]

Description was changed from

==========
[csa] Add ToLength and ToString variants with inlined fast checks

Smis can easily be handled outside the stub call without adding much to code
size.

The ToString inlining adds overhead of repeated instance type loads and checks,
but under the assumption that it is called with mostly string values it should
speed things up (a local RegExp.p[@@replace] microbenchmark shows consistent
1.6% improvements).

BUG=
==========

to

==========
[csa] Add ToLength and ToString variants with inlined fast checks

Smis can easily be handled outside the stub call without adding much to code
size.

The ToString inlining adds overhead of repeated instance type loads and checks,
but under the assumption that it is called with mostly string values it should
speed things up (a local RegExp.p[@@replace] microbenchmark shows consistent
1.6% improvements).

Drive-by-fix: Remove duplication in ToString implementations.

BUG=
==========

[commit-bot: I haz the power, 2017-05-12 14:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 14:28:57]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2017-05-15 07:08:01]

lgtm

[jgruber, 2017-05-15 07:13:58]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-05-15 07:14:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 07:51:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494832438636300,
"parent_rev": "3a80814d53ab706b61e5a862692a053b0bb04103", "commit_rev":
"646fdacaa790fa29f0a7224a513c6514ecb9f627"}

[commit-bot: I haz the power, 2017-05-15 07:51:22]

Description was changed from

==========
[csa] Add ToLength and ToString variants with inlined fast checks

Smis can easily be handled outside the stub call without adding much to code
size.

The ToString inlining adds overhead of repeated instance type loads and checks,
but under the assumption that it is called with mostly string values it should
speed things up (a local RegExp.p[@@replace] microbenchmark shows consistent
1.6% improvements).

Drive-by-fix: Remove duplication in ToString implementations.

BUG=
==========

to

==========
[csa] Add ToLength and ToString variants with inlined fast checks

Smis can easily be handled outside the stub call without adding much to code
size.

The ToString inlining adds overhead of repeated instance type loads and checks,
but under the assumption that it is called with mostly string values it should
speed things up (a local RegExp.p[@@replace] microbenchmark shows consistent
1.6% improvements).

Drive-by-fix: Remove duplication in ToString implementations.

BUG=

Review-Url: https://codereview.chromium.org/2874423003
Cr-Commit-Position: refs/heads/master@{#45287}
Committed:
https://chromium.googlesource.com/v8/v8/+/646fdacaa790fa29f0a7224a513c6514ecb...
==========

[commit-bot: I haz the power, 2017-05-15 07:51:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/646fdacaa790fa29f0a7224a513c6514ecb...