Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2874363002: [DevTools] Make async step in marker contiguous (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 } 508 }
509 509
510 /** 510 /**
511 * @param {!MouseEvent} event 511 * @param {!MouseEvent} event
512 */ 512 */
513 _onMouseMove(event) { 513 _onMouseMove(event) {
514 if (this._executionLocation && this._controlDown && UI.KeyboardShortcut.even tHasCtrlOrMeta(event)) { 514 if (this._executionLocation && this._controlDown && UI.KeyboardShortcut.even tHasCtrlOrMeta(event)) {
515 if (!this._continueToLocationDecorations) 515 if (!this._continueToLocationDecorations)
516 this._showContinueToLocations(); 516 this._showContinueToLocations();
517 } 517 }
518 if (this._continueToLocationDecorations) {
519 this.textEditor.element.classList.toggle(
520 'source-frame-async-step-in-hovered',
521 !!event.target.enclosingNodeOrSelfWithClass('source-frame-async-step-i n'));
522 }
518 } 523 }
519 524
520 /** 525 /**
521 * @param {!MouseEvent} event 526 * @param {!MouseEvent} event
522 */ 527 */
523 _onMouseDown(event) { 528 _onMouseDown(event) {
524 if (!this._executionLocation || !UI.KeyboardShortcut.eventHasCtrlOrMeta(even t)) 529 if (!this._executionLocation || !UI.KeyboardShortcut.eventHasCtrlOrMeta(even t))
525 return; 530 return;
526 if (!this._continueToLocationDecorations) 531 if (!this._continueToLocationDecorations)
527 return; 532 return;
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
908 }); 913 });
909 } 914 }
910 915
911 _clearContinueToLocationsNoRestore() { 916 _clearContinueToLocationsNoRestore() {
912 if (!this._continueToLocationDecorations) 917 if (!this._continueToLocationDecorations)
913 return; 918 return;
914 this.textEditor.operation(() => { 919 this.textEditor.operation(() => {
915 for (var decoration of this._continueToLocationDecorations.keys()) 920 for (var decoration of this._continueToLocationDecorations.keys())
916 this.textEditor.removeHighlight(decoration); 921 this.textEditor.removeHighlight(decoration);
917 this._continueToLocationDecorations = null; 922 this._continueToLocationDecorations = null;
923 this.textEditor.element.classList.remove('source-frame-async-step-in-hover ed');
918 }); 924 });
919 } 925 }
920 926
921 _clearContinueToLocations() { 927 _clearContinueToLocations() {
922 if (!this._continueToLocationDecorations) 928 if (!this._continueToLocationDecorations)
923 return; 929 return;
924 this.textEditor.operation(() => { 930 this.textEditor.operation(() => {
925 this.textEditor.showExecutionLineBackground(); 931 this.textEditor.showExecutionLineBackground();
926 this._generateValuesInSource(); 932 this._generateValuesInSource();
927 this._clearContinueToLocationsNoRestore(); 933 this._clearContinueToLocationsNoRestore();
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
1571 return; 1577 return;
1572 this.bookmark.clear(); 1578 this.bookmark.clear();
1573 this.bookmark = null; 1579 this.bookmark = null;
1574 } 1580 }
1575 }; 1581 };
1576 1582
1577 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); 1583 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark');
1578 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); 1584 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element');
1579 1585
1580 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark'); 1586 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark');
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698