Issue 2874323002: Check if tab is null before requesting theme color

Issue 2874323002: Check if tab is null before requesting theme color (Closed)

Created:
3 years, 7 months ago by mdjones

Modified:
3 years, 7 months ago

Reviewers:
Theresa

CC:
chromium-reviews, agrieve+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Check if tab is null before requesting theme color The toolbar scenelayer will draw even if the user is in the tab switcher with no tabs. This null check prevents requesting a default theme color from a nonexistent tab. BUG=720213 Review-Url: https://codereview.chromium.org/2874323002 Cr-Commit-Position: refs/heads/master@{#471117} Committed: https://chromium.googlesource.com/chromium/src/+/05f1677728d0bde892c5f21945ca8054d3f80a20

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874323002/1

3 years, 7 months ago (2017-05-11 21:35:04 UTC) #5

commit-bot: I haz the power

3 years, 7 months ago (2017-05-11 23:26:31 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05f1677728d0bde892c5f21945ca...