Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2874313002: Fix is_browser_shortcut; add a test.

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix is_browser_shortcut; add a test. BUG=709765 TEST=the new BrowserKeyEventsTest.InputBrowserShortcut

Patch Set 1 #

Patch Set 2 : use a browser command valid on all platforms #

Patch Set 3 : try with the browsershortcut #

Patch Set 4 : SendKeyPressSync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -9 lines) Patch
M chrome/browser/browser_keyevents_browsertest.cc View 1 2 3 2 chunks +76 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 2 chunks +17 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 chunks +22 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/UserGestureIndicator.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (14 generated)
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 20:29:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874313002/1
3 years, 7 months ago (2017-05-11 20:30:42 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 21:18:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874313002/20001
3 years, 7 months ago (2017-05-11 21:19:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-11 22:25:54 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/451460)
3 years, 7 months ago (2017-05-11 22:25:54 UTC) #6
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-24 22:10:13 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874313002/40001
3 years, 5 months ago (2017-06-24 22:10:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-24 23:22:22 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/485370)
3 years, 5 months ago (2017-06-24 23:22:23 UTC) #10
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-06-29 21:20:09 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874313002/60001
3 years, 5 months ago (2017-06-29 21:20:34 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-29 22:22:04 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 22:22:05 UTC) #14 
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698