Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2874313002: Fix is_browser_shortcut; add a test.
Patch Set: SendKeyPressSync Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/UserGestureIndicator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
index 6ce5ab71a9b1222a6ee9b6f724328d31017cbc45..26dccc4924906eedb58b443af7c127ead47bde10 100644
--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
@@ -166,6 +166,7 @@ bool KeyboardEventManager::HandleAccessKey(const WebKeyboardEvent& evt) {
WebInputEventResult KeyboardEventManager::KeyEvent(
const WebKeyboardEvent& initial_key_event) {
+ LOG(ERROR) << "KeyboardEventManager::KeyEvent";
frame_->GetChromeClient().ClearToolTip(*frame_);
if (initial_key_event.windows_key_code == VK_CAPITAL)
@@ -196,6 +197,17 @@ WebInputEventResult KeyboardEventManager::KeyEvent(
bool is_modifier =
Platform::Current()->IsDomKeyForModifier(initial_key_event.dom_key);
bool is_browser_shortcut = initial_key_event.is_browser_shortcut;
+ LOG(ERROR) << "initial_key_event.GetType() " << initial_key_event.GetType();
+ LOG(ERROR) << "initial_key_event.is_browser_shortcut "
+ << initial_key_event.is_browser_shortcut;
+ LOG(ERROR) << "initial_key_event.windows_key_code "
+ << initial_key_event.windows_key_code;
+ LOG(ERROR) << "initial_key_event.dom_code " << initial_key_event.dom_code;
+ LOG(ERROR) << "initial_key_event.dom_key " << initial_key_event.dom_key;
+ LOG(ERROR) << "initial_key_event.text[0] " << initial_key_event.text[0] << " "
+ << (initial_key_event.text[0] ? ((char)initial_key_event.text[0])
+ : ' ');
+ LOG(ERROR) << "is_modifier " << is_modifier;
std::unique_ptr<UserGestureIndicator> gesture_indicator;
if (!is_modifier && !is_browser_shortcut) {
« no previous file with comments | « third_party/WebKit/Source/core/dom/UserGestureIndicator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698