Fork PIN keyboard assets and create additional flag for lock screen

Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

The two flags should not be used together.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2874303003
Cr-Commit-Position: refs/heads/master@{#471449}
Committed: https://chromium.googlesource.com/chromium/src/+/be738df8f289bf20423865f1bc555f2976a2e921

[Wenzhao (Colin) Zang, 2017-05-11 22:03:39]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

BUG=718174
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-11 22:15:24]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

The lock screen and PIN keyboard assets are forked so that it's 
implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-11 22:15:24]

wzang@chromium.org changed reviewers:
+ alemate@chromium.org, jdufault@chromium.org

[Wenzhao (Colin) Zang, 2017-05-11 22:16:25]

wzang@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Wenzhao (Colin) Zang, 2017-05-11 22:16:49]

wzang@chromium.org changed reviewers:
- alemate@chromium.org

[Wenzhao (Colin) Zang, 2017-05-11 22:17:31]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

The lock screen and PIN keyboard assets are forked so that it's 
implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

The lock screen and PIN keyboard assets are forked so that the new design 
of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-11 22:19:07]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

The lock screen and PIN keyboard assets are forked so that the new design 
of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new design of
lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-11 22:19:15]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new design of
lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-11 22:22:28]

xiyuan@, jdufault@, please take a look. This CL forks additional assets and has
very few actual changes. Thanks so much.

[jdufault, 2017-05-11 23:05:57]

I think you need to rebase, if --show-md-login is passed we show the views based
lock screen. You'll need to modify screen_locker.cc to also check for the new
flag.

[Wenzhao (Colin) Zang, 2017-05-11 23:15:48]

On 2017/05/11 23:05:57, jdufault wrote:
> I think you need to rebase, if --show-md-login is passed we show the views
based
> lock screen. You'll need to modify screen_locker.cc to also check for the new
> flag.

Not sure if I understand correctly, but my intention is that when using
--show-md-login only,
the views based lock screen and login screen (TODO) will be shown. When using
the new flag only,
the login screen and lock screen which I'm currently working on will be shown.
There is no use 
case of using the two flags together. That's why I did not check for the new
flag in screen_locker.cc.

[jdufault, 2017-05-11 23:20:46]

On 2017/05/11 23:15:48, Wenzhao (Colin) Zang wrote:
> On 2017/05/11 23:05:57, jdufault wrote:
> > I think you need to rebase, if --show-md-login is passed we show the views
> based
> > lock screen. You'll need to modify screen_locker.cc to also check for the
new
> > flag.
> 
> Not sure if I understand correctly, but my intention is that when using
> --show-md-login only,
> the views based lock screen and login screen (TODO) will be shown. When using
> the new flag only,
> the login screen and lock screen which I'm currently working on will be shown.
> There is no use 
> case of using the two flags together. That's why I did not check for the new
> flag in screen_locker.cc.

Discussed offline, I was assuming both flags would be passed at the same time.
Only one will be in use.

https://codereview.chromium.org/2874303003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/2874303003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:166: if
(command_line->HasSwitch(chromeos::switches::kShowNonViewMdLogin)) {
We still need to show the md webui if --show-md-login is passed.

[Wenzhao (Colin) Zang, 2017-05-11 23:26:33]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

There is no point of using the two flags together.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-11 23:49:55]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

There is no point of using the two flags together.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

The two flags should not be used together.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-05-11 23:50:48]

https://codereview.chromium.org/2874303003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://codereview.chromium.org/2874303003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:166: if
(command_line->HasSwitch(chromeos::switches::kShowNonViewMdLogin)) {
On 2017/05/11 23:20:46, jdufault wrote:
> We still need to show the md webui if --show-md-login is passed.

--show-md-login is added back. I think in the future when views-based login is
being developed the flag will be moved away from here.

[jdufault, 2017-05-11 23:56:22]

lgtm, make sure you capture the pin keyboard changes in
https://codereview.chromium.org/2848483002/

[xiyuan, 2017-05-12 17:51:58]

lgtm

[Wenzhao (Colin) Zang, 2017-05-12 19:13:30]

The CQ bit was checked by wzang@chromium.org

[commit-bot: I haz the power, 2017-05-12 19:14:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 20:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 20:04:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Wenzhao (Colin) Zang, 2017-05-12 20:10:09]

The CQ bit was checked by wzang@chromium.org

[commit-bot: I haz the power, 2017-05-12 20:10:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 21:36:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494619809419120,
"parent_rev": "42a0166c209d0fbc20e0adb4bf352571804e0a07", "commit_rev":
"be738df8f289bf20423865f1bc555f2976a2e921"}

[commit-bot: I haz the power, 2017-05-12 21:36:37]

Description was changed from

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

The two flags should not be used together.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fork PIN keyboard assets and create additional flag for lock screen

Fork relevant assets (as follow-up to CL 2855883005) so that the new
design of lock screen can be implemented in tandem with login screen.

The recently added flag (kShowMdLogin) is reserved for views-based login
and lock screen as they are being implemented.

The new flag added by this CL (kShowNonViewMdLogin) is a temporary flag
used until the views-based screens become available.

The two flags should not be used together.

BUG=718174
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2874303003
Cr-Commit-Position: refs/heads/master@{#471449}
Committed:
https://chromium.googlesource.com/chromium/src/+/be738df8f289bf20423865f1bc55...
==========

[commit-bot: I haz the power, 2017-05-12 21:36:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be738df8f289bf20423865f1bc55...