Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2874283002: [Media Router] Notify MRUI of a media status update when it starts observing (Closed)

Created:
3 years, 7 months ago by takumif
Modified:
3 years, 7 months ago
Reviewers:
mark a. foltz
CC:
Aaron Boodman, abarth-chromium, chfremer+watch_chromium.org, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, imcheng+watch_chromium.org, mfoltz+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Notify MRUI of a media status update when it starts observing When the browser-side MediaRouteController already existed for a route, new observers weren't getting notified of media status updates until there were further updates. This change makes MRUI get notified when it starts observing. BUG=684638 Review-Url: https://codereview.chromium.org/2874283002 Cr-Commit-Position: refs/heads/master@{#471917} Committed: https://chromium.googlesource.com/chromium/src/+/f5128acd5e3d64e615280d77f43d685641a21ee0

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Mark's comments #

Total comments: 6

Patch Set 3 : Address Mark's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M chrome/browser/media/router/mojo/media_route_controller.h View 1 2 4 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/media/router/mojo/media_route_controller.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc View 2 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
takumif
Please take a look, thanks!
3 years, 7 months ago (2017-05-11 17:45:09 UTC) #4
takumif
(Changing to mfoltz@chromium instead of mfoltz@google)
3 years, 7 months ago (2017-05-11 17:46:25 UTC) #6
mark a. foltz
https://codereview.chromium.org/2874283002/diff/1/chrome/browser/media/router/mojo/media_route_controller.h File chrome/browser/media/router/mojo/media_route_controller.h (right): https://codereview.chromium.org/2874283002/diff/1/chrome/browser/media/router/mojo/media_route_controller.h#newcode49 chrome/browser/media/router/mojo/media_route_controller.h:49: void CheckForMediaStatusUpdates(); Is this necessary? https://codereview.chromium.org/2874283002/diff/1/chrome/browser/ui/webui/media_router/media_router_ui.cc File chrome/browser/ui/webui/media_router/media_router_ui.cc (right): ...
3 years, 7 months ago (2017-05-12 21:00:58 UTC) #7
takumif
https://codereview.chromium.org/2874283002/diff/1/chrome/browser/media/router/mojo/media_route_controller.h File chrome/browser/media/router/mojo/media_route_controller.h (right): https://codereview.chromium.org/2874283002/diff/1/chrome/browser/media/router/mojo/media_route_controller.h#newcode49 chrome/browser/media/router/mojo/media_route_controller.h:49: void CheckForMediaStatusUpdates(); On 2017/05/12 21:00:58, mark a. foltz wrote: ...
3 years, 7 months ago (2017-05-12 22:20:58 UTC) #10
mark a. foltz
lgtm % comments https://codereview.chromium.org/2874283002/diff/60001/chrome/browser/media/router/mojo/media_route_controller.cc File chrome/browser/media/router/mojo/media_route_controller.cc (right): https://codereview.chromium.org/2874283002/diff/60001/chrome/browser/media/router/mojo/media_route_controller.cc#newcode72 chrome/browser/media/router/mojo/media_route_controller.cc:72: current_media_status_ = base::make_optional<MediaStatus>(MediaStatus(status)); I don't think ...
3 years, 7 months ago (2017-05-12 23:06:19 UTC) #11
takumif
Thanks for reviewing! https://codereview.chromium.org/2874283002/diff/60001/chrome/browser/media/router/mojo/media_route_controller.cc File chrome/browser/media/router/mojo/media_route_controller.cc (right): https://codereview.chromium.org/2874283002/diff/60001/chrome/browser/media/router/mojo/media_route_controller.cc#newcode72 chrome/browser/media/router/mojo/media_route_controller.cc:72: current_media_status_ = base::make_optional<MediaStatus>(MediaStatus(status)); On 2017/05/12 23:06:18, ...
3 years, 7 months ago (2017-05-15 17:57:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874283002/80001
3 years, 7 months ago (2017-05-15 21:53:19 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 22:07:27 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f5128acd5e3d64e615280d77f43d...

Powered by Google App Engine
This is Rietveld 408576698