DevTools: Tweak Group by Product

DevTools: Tweak Group by Product

Show domain names for entries that have no product associated.
Color unmatched domain names with grey.

BUG=718655
Review-Url: https://codereview.chromium.org/2874273003
Cr-Commit-Position: refs/heads/master@{#471261}
Committed: https://chromium.googlesource.com/chromium/src/+/2cc4ba79f53e6d0073d51343cbbbc4f1f5739952

[alph, 2017-05-12 00:27:50]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-05-12 00:56:13]

lgtm

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:711:
var name = this._productByEvent(/** @type {!SDK.TracingModel.Event} */
(node.event));
var productName = ...

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:713:
name = name || this._domainByEvent(true, /** @type {!SDK.TracingModel.Event} */
(node.event)) || '';
var name = productName || ...

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:856:
var url = TimelineModel.TimelineProfileTree.eventURL(event) || '';
if (!url)
  return '';?

[alph, 2017-05-12 01:08:45]

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
(right):

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:711:
var name = this._productByEvent(/** @type {!SDK.TracingModel.Event} */
(node.event));
On 2017/05/12 00:56:13, caseq wrote:
> var productName = ...

Done.

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:713:
name = name || this._domainByEvent(true, /** @type {!SDK.TracingModel.Event} */
(node.event)) || '';
On 2017/05/12 00:56:12, caseq wrote:
> var name = productName || ...

Done.

https://codereview.chromium.org/2874273003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:856:
var url = TimelineModel.TimelineProfileTree.eventURL(event) || '';
On 2017/05/12 00:56:13, caseq wrote:
> if (!url)
>   return '';?

Done.

[alph, 2017-05-12 01:08:49]

The CQ bit was checked by alph@chromium.org

[alph, 2017-05-12 01:08:49]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2874273003/#ps20001
(title: "4 landing")

[commit-bot: I haz the power, 2017-05-12 01:09:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:24:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 05:24:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alph, 2017-05-12 06:02:32]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-05-12 06:02:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 09:47:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494568952686300,
"parent_rev": "c5106fdfb45ca1c85f5018dfbf0989d3c97db323", "commit_rev":
"2cc4ba79f53e6d0073d51343cbbbc4f1f5739952"}

[commit-bot: I haz the power, 2017-05-12 09:47:32]

Description was changed from

==========
DevTools: Tweak Group by Product

Show domain names for entries that have no product associated.
Color unmatched domain names with grey.

BUG=718655
==========

to

==========
DevTools: Tweak Group by Product

Show domain names for entries that have no product associated.
Color unmatched domain names with grey.

BUG=718655

Review-Url: https://codereview.chromium.org/2874273003
Cr-Commit-Position: refs/heads/master@{#471261}
Committed:
https://chromium.googlesource.com/chromium/src/+/2cc4ba79f53e6d0073d51343cbbb...
==========

[commit-bot: I haz the power, 2017-05-12 09:47:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2cc4ba79f53e6d0073d51343cbbb...